Add VP6[A] video decoding support #5369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmeisthax
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
This more or less looks good to me. I'll merge after the repo transfer (so you have a chance to update the Cargo ref).
I merged the h263-rs PR you mentioned, so you might want to bump that at some point. You should also ensure the documentation on licensing makes it to LICENSE.md's third-party software table (which, itself, probably needs updating).
torokati44
force-pushed
the
video-vp6-nihav
branch
from
4784faa
to
78da7f1
Compare
|
I have transferred the repo, updated the Cargo.toml ref, and added a line to LICENSE.md about this. Thank you for merging the h263-rs PR. I will submit a separate dependency bump for that soon - I didn't want to bunch that up into these changes. |
|
I have just now realized that we might be waiting for each other, because I was entirely unclear about the h263-rs git bump. |
torokati44
force-pushed
the
video-vp6-nihav
branch
2 times, most recently
from
01ef816
to
c711676
Compare
kmeisthax
approved these changes
Oct 3, 2021
torokati44
force-pushed
the
video-vp6-nihav
branch
from
c711676
to
69f6caf
Compare
Herschel
approved these changes
Oct 3, 2021
|
Getting a panic on the following file |
Herschel
reviewed
Oct 3, 2021
Gated behind the "vp6" feature, enabled by default. Utilizing a heavily stripped-down version of the NihAV project, retaining only the VP6 decoder, relicensed under MIT. Including VP6WithAlpha decoding, proper FrameDependency reporting, and cropping the unwanted encoded pixels on the right/bottom manually.
torokati44
force-pushed
the
video-vp6-nihav
branch
from
69f6caf
to
f9d2522
Compare
|
Thanks a lot for checking, I found the cause of the panic and fixed it. I didn't skip the first 24 bits encoding the offset to the alpha frame, which precede the proper VP6 header. The decoder itself does this on its own, which is why it worked with fixed sizes. |
This was referenced Oct 5, 2021
Closed
|
@torokati44 Fantastic work, thank you so much! Being able to view embedded videos in flash loops does a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #3004.
In contrast to that:
clang, no iffy FFI, no funky business with adding a quasi-libc on web, and no CI troubles.This is more in line with what the H.263 decoder added, which was about 80k, although that was including the colorspace conversion code.
h263-rs-yuvfor the colorspace conversion.Most likely as a result of this, it is measurably slower, at least on web. See for example: https://z0r.de/2289
Merging yuv: Remove chroma interpolation, use iterators h263-rs#13 (then bumping the crate git ref) and web: Enable the bulk-memory WebAssembly extension #5225 should alleviate this somewhat.
Some more size reduction can be achieved by dropping a few more parts that are not strictly necessary, but I think this is already acceptable.
Thanks again to the author: https://codecs.multimedia.cx/nihav-relicensed-code/
unsafeblocks, aside from a few really small ones, in a single file, in one of the the decoder crates.Similar to that:
vp6feature toruffle-core, enabled by default.VP6WithAlphadecoding andFrameDependency(keyframe) reporting.bounds.I plan to move ownership of https://github.com/torokati44/nihav-vp6 to the Ruffle organization after review, but before merging.