New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imports of .d.ts definitions for JS gRPC rules #134

Merged

aaliddell merged 1 commit into rules-proto-grpc:dev from amari:grpc_node_ts_plugin-fixes

Sep 14, 2021

Contributor

amari commented Aug 11, 2021

The generated .d.ts files were importing grpc instead of @grpc/grpc-js b/c ts-protoc-gen was being invoked without the mode=grpc-js option.


          Fix imports of .d.ts definitions for JS gRPC rules

b69521d

github-actions bot added the lang-js label

aaliddell added the bug label

aaliddell changed the base branch from master to dev

September 14, 2021 18:56

Member

aaliddell commented Sep 14, 2021

Merging to dev in preparation for 4.0.0 release, thanks 👍

aaliddell merged commit 47a2a38 into rules-proto-grpc:dev

aaliddell mentioned this pull request

@grpc/grpc-js instead of native grpc #144

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels