Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --tf-download-url flag #903

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Add --tf-download-url flag #903

merged 2 commits into from
Jan 20, 2020

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Jan 20, 2020

Add new --tf-download-url flag that configures where Terraform is downloaded from. Defaults to https://releases.hashicorp.com. This can be used in environments where calls to https://releases.hashicorp.com are firewalled.

Notes:

cullenmcdermott and others added 2 commits January 20, 2020 09:19
* Fix bad ordering of args calling NewClient()
* Make error messages clearer
@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #903 into master will increase coverage by 0.02%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #903      +/-   ##
==========================================
+ Coverage   71.83%   71.86%   +0.02%     
==========================================
  Files          65       65              
  Lines        5213     5218       +5     
==========================================
+ Hits         3745     3750       +5     
  Misses       1183     1183              
  Partials      285      285
Impacted Files Coverage Δ
server/user_config.go 100% <ø> (ø) ⬆️
server/server.go 63.69% <100%> (+0.11%) ⬆️
cmd/server.go 78.97% <100%> (+0.19%) ⬆️
server/events/terraform/terraform_client.go 78.15% <72.72%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a57e28...84e41ce. Read the comment docs.

@lkysow lkysow merged commit 8232630 into master Jan 20, 2020
@lkysow lkysow deleted the download-url branch January 20, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring custom releasesURL
2 participants