Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Group Ironmen Tracker plugin #2589

Merged
merged 6 commits into from
Apr 29, 2022

Conversation

christoabrown
Copy link
Contributor

Sends character information for group ironmen where other members can view. Groups will need to go to the site to create a new group and are provided with credentials for login and sending the data.

groupiron.men
Demo of what it looks like logged in is also available: Demo

This version sends the following information, all of it is encrypted before being stored:

  • Inventory, bank, equipment, and shared bank
  • HP, prayer, energy, and world
  • World position
  • Skill XP
  • Quest states

Source code for the server and frontend is here:
https://github.com/christoabrown/group-ironmen

It seems somewhat similar to the other tracker plugins, although I believe having a public server with a DB and login credentials sets it apart. I do also intend to add more features like more inventories, achievement diaries, etc.

@runelite-github-app
Copy link

runelite-github-app bot commented Apr 23, 2022

@Nightfirecat
Copy link
Member

As far as I'm concerned, the warning you've added isn't needed--no requests are sent without making configuration changes.

You should set a unique user agent for this plugin for requests it submits.

@christoabrown
Copy link
Contributor Author

I removed the warning and included the custom user agent.

@Nightfirecat
Copy link
Member

You don't need to make a whole new Okhttp client, just add .header("User-Agent", USER_AGENT) in your request builders.

@christoabrown
Copy link
Contributor Author

That's what I tried at first, but wherever this client is being built it is adding its own user-agent header before sending the request. I am not super familiar with the runelite code, but I am guessing it is here the interceptor is added which overrides the header:
https://github.com/runelite/runelite/blob/master/runelite-client/src/main/java/net/runelite/client/RuneLite.java#L439

@Adam-
Copy link
Member

Adam- commented Apr 28, 2022

That's what I tried at first, but wherever this client is being built it is adding its own user-agent header before sending the request. I am not super familiar with the runelite code, but I am guessing it is here the interceptor is added which overrides the header: https://github.com/runelite/runelite/blob/master/runelite-client/src/main/java/net/runelite/client/RuneLite.java#L439

This is a bug which I've fixed runelite/runelite@c40b33a

@christoabrown
Copy link
Contributor Author

Thanks for the fix. I changed it so it now uses @Nightfirecat's suggestion with setHeader which I expect will start working in a future runelite release.

@Nightfirecat Nightfirecat merged commit 6dc015c into runelite:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants