Skip to content

Commit

Permalink
fix: build rootfs workflow not uploading the artifacts to S3 (#345)
Browse files Browse the repository at this point in the history
Issue #, if available:
Found via https://github.com/runfinch/finch-core/actions/runs/9686876109

*Description of changes:*
This change adds --recursive flag to the aws s3 cp command to apply the
copy to S3 bucket to all files on the local path which match the
artifact pattern.

*Testing done:*
Tested aws s3 cp locally using `--recursive` flag.

- [x] I've reviewed the guidance in CONTRIBUTING.md

#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
  • Loading branch information
austinvazquez authored Jun 26, 2024
1 parent d7e0600 commit 19274d9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/rootfs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,4 @@ jobs:
fi
# Upload tarball and shasum to S3
aws s3 cp . s3://${{ secrets.DEPENDENCY_BUCKET_NAME }}/${{ matrix.platform }}/$ARCHPATH/ --exclude "*" --include "finch-rootfs-production-${{ matrix.arch }}-"$TIMESTAMP".tar.gz*"
aws s3 cp . s3://${{ secrets.DEPENDENCY_BUCKET_NAME }}/${{ matrix.platform }}/$ARCHPATH/ --recursive --exclude "*" --include "finch-rootfs-production-${{ matrix.arch }}-"$TIMESTAMP".tar.gz*"

0 comments on commit 19274d9

Please sign in to comment.