Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Finch on Windows rootfs update workflow #343

Merged

Conversation

austinvazquez
Copy link
Member

@austinvazquez austinvazquez commented Jun 26, 2024

Issue #, if available:
In #326, it was found the update rootfs workflow was not working due to the filename pattern still searching for .zst archives. The pattern was updated to .gz to match the release archives in S3; however, the regular expression does not work with grep's basic regular expression engine.

Description of changes:
This change updates the find in S3 utility function to use grep's extended regular expression engine and updates the filename patterns.

Testing done:
Tested using local aws S3 queries:

Rootfs bundle:

macedonv@localhost:~$ aws s3 ls s3://***/common/x86-64 --recursive | grep -E 'finch-rootfs-production-amd64-[0-9]+\.tar\.gz$' | tail -n 1 | sort | awk '{print $4}'
common/x86-64/finch-rootfs-production-amd64-1715724303.tar.gz
macedonv@localhost:~$ 

Lima bundle:

macedonv@localhost:~$ aws s3 ls s3://***/aarch64 --recursive | grep -E 'lima-and-qemu.macos-aarch64\.[0-9]+\.tar\.gz$' | tail -n 1 | sort | awk '{print $4}'
aarch64/lima-and-qemu.macos-aarch64.1719307443.tar.gz
macedonv@localhost:~$ 
  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This change updates the find artifact in s3 utility function to use
grep's extended regex and updates the rootfs and lima bundle filename
patterns for it.

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@austinvazquez austinvazquez marked this pull request as ready for review June 26, 2024 20:05
@austinvazquez austinvazquez merged commit 394363b into runfinch:main Jun 26, 2024
10 checks passed
@austinvazquez austinvazquez deleted the fix-update-rootfs-workflow branch June 26, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants