build(deps): Bump finch dependencies #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1 task
austinvazquez
requested changes
Jun 26, 2024
There was a problem hiding this comment.
Artifact should be basename only. Opened #347 to resolve. Manually edit changes here for correctness.
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
create-pull-request/patch
branch
from
96671ba
to
edc49e5
Compare
pendo324
approved these changes
Jun 26, 2024
austinvazquez
added a commit
that referenced
this pull request
Jun 26, 2024
…347) Issue #, if available: Found in #346 *Description of changes:* This change updates update-rootfs.sh and update-deps.sh to write the artifact basename to the ARTIFACT configuration variable. *Testing done:* Locally tested in bash: ``` aarch64_deps="aarch64/lima-and-qemu.macos-aarch64.1719307443.tar.gz" echo "AARCH64_ARTIFACT=$(basename "${aarch64_deps}")" ``` - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action