Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finch build with multiple tags (-t) only updates the first tag when the tag already exists #707

Open
mcmathews opened this issue Nov 29, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mcmathews
Copy link

Describe the bug
When running finch build specifying multiple tags for the built container (multiple -t arguments), only the first tag is updated if the tags already exist.

Steps to reproduce
The following steps demonstrate the problem.

% echo 'FROM busybox
CMD ["echo", "1"]
' > Dockerfile

% finch build . -t test:tag1 -t test:tag2 -q

% finch run test:tag1
1

% finch run test:tag2
1

% echo 'FROM busybox
CMD ["echo", "2"]
' > Dockerfile

% finch build . -t test:tag1 -t test:tag2 -q

% finch run test:tag1
2

% finch run test:tag2
1

As you can see, after the dockerfile is changed and the container is rebuilt with the same tags, the second tag isn't updated.

Expected behavior
The output of running the 2 containers that should have been built in the build step should be the same. More generally, each finch build should update ALL the tags given to the container that is built.

Screenshots or logs
N/A

Additional context
None

To help debug the issue as quickly as possible, we recommend generating a support bundle with finch support-bundle generate and attaching it to this issue. This packages all Finch-related configs and logs into one file.

@mcmathews mcmathews added the bug Something isn't working label Nov 29, 2023
@mcmathews
Copy link
Author

@weikequ weikequ self-assigned this Dec 4, 2023
@weikequ
Copy link
Contributor

weikequ commented Dec 4, 2023

Thanks for submitting the issue! I can reproduce the behaviour on my machine with both finch as well as nerdctl. Will open an issue and try submitting a fix with nerdctl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants