Building with multiple tags only updates the first tag

[weikequ]

Description

First seen here: runfinch/finch#707.

When running build while specifying multiple tags for the container, only the first tag is updated if the tags already exist.

Steps to reproduce the issue

echo 'FROM busybox
CMD ["echo", "1"]
' > Dockerfile

sudo nerdctl build . -t test:tag1 -t test:tag2 -q

sudo nerdctl run test:tag1
# 1

sudo nerdctl run test:tag2
# 1

echo 'FROM busybox
CMD ["echo", "2"]
' > Dockerfile

sudo nerdctl build . -t test:tag1 -t test:tag2 -q

sudo nerdctl run test:tag1
# 2

sudo nerdctl run test:tag2
# 1 (but should be 2)

Describe the results you received and expected

See steps above.

What version of nerdctl are you using?

1.7.1

Are you using a variant of nerdctl? (e.g., Rancher Desktop)

None

Host information

No response

[weikequ]

I am happy to work on this and contribute a fix

[weikequ]

Seems like this is the issue in the code. Does anyone have any context on why we decided to skip images that already exist if it's not the first image? Related/caused by this conversation.

nerdctl/pkg/cmd/builder/build.go

Lines 99 to 111 in d993af5

	if len(tags) > 1 {
	log.L.Debug("Found more than 1 tag")
	imageService := client.ImageService()
	image, err := imageService.Get(ctx, tags[0])
	if err != nil {
	return fmt.Errorf("unable to tag image: %s", err)
	}
	for _, targetRef := range tags[1:] {
	image.Name = targetRef
	if _, err := imageService.Create(ctx, image); err != nil {
	// if already exists; skip.
	if errors.Is(err, errdefs.ErrAlreadyExists) {
	continue

[AkihiroSuda]

Cc @manugupt1

[manugupt1]

I will look at this sometime this month and try to fix it. AFAIR, I did not think of this case.

[manugupt1]

This fixed. Closing.