-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bundle fails to be created on Windows #897
Labels
bug
Something isn't working
Comments
haytok
added a commit
to haytok/finch
that referenced
this issue
Jun 12, 2024
…re the `uname` command does not exist On Windows environments where the `uname` command is not available, executing `finch support-bundle generate` results in the following error: ``` C:\Users\simpl>"..\..\Program Files\Finch\bin\finch.exe" support-bundle generate time="2024-06-11T23:21:16+09:00" level=info msg="Generating support bundle..." time="2024-06-11T23:21:16+09:00" level=fatal msg="exec: \"uname\": executable file not found in %PATH%" ``` This bug has been reported in the following issue: - runfinch#897 Therefore, this fix enables the execution of `finch support-bundle generate` even when the `uname` command is not available on Windows. Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
1 task
pendo324
pushed a commit
that referenced
this issue
Jun 20, 2024
#976) …re the `uname` command does not exist On Windows environments where the `uname` command is not available, executing `finch support-bundle generate` results in the following error: ``` C:\Users\simpl>"..\..\Program Files\Finch\bin\finch.exe" support-bundle generate time="2024-06-11T23:21:16+09:00" level=info msg="Generating support bundle..." time="2024-06-11T23:21:16+09:00" level=fatal msg="exec: \"uname\": executable file not found in %PATH%" ``` This bug has been reported in the following issue: - #897 Therefore, this fix enables the execution of `finch support-bundle generate` even when the `uname` command is not available on Windows. Issue #, if available: #897 *Description of changes:* The details are described in this commit message. *Testing done:* Yes - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
Resolved by #976 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
On Windows, running
finch support-bundle generate
fails with the following error:Steps to reproduce
Run
finch support-bundle generate
on Windows.Expected behavior
A support bundle should be created.
Screenshots or logs
If applicable, add screenshots or logs to help explain your problem.
Additional context
The reason this issue occurs is because pkg/support/support.go's
getArch
function callsuname
on the host system, and Windows does not have auname
executable.getArch
should be scoped to OS-specific files for UNIX and Windows.To help debug the issue as quickly as possible, we recommend generating a support bundle with
finch support-bundle generate
and attaching it to this issue. This packages all Finch-related configs and logs into one file.The text was updated successfully, but these errors were encountered: