Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: override provisioning script #1043

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shubhranshu153
Copy link
Contributor

Issue #, if available:

Description of changes:
Fix override provisioning script to add provisioning script only with qemu

Testing done:
Local Testing

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Shubhranshu153 Shubhranshu153 changed the title Fix override provisioning script fix: override provisioning script Jul 22, 2024
@pendo324
Copy link
Member

qemu user mode emulation binaries should still be configurable when using Virtualization.framework. There may be workloads which do not work under Rosetta emulation, but do work under qemu's emulation (which is why they have separate toggles in finch.yaml).

If both Rosetta and qemu-binfmt binaries are configured, Rosetta should be the one used due to Linux implementation details (I don't think its documented).

…systems

Signed-off-by: Shubharanshu Mahapatra <shubhum@amazon.com>
@Shubhranshu153 Shubhranshu153 force-pushed the fix-override-provisioning-script branch from fd931ce to dc77e4a Compare July 24, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants