Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Amazon ECR credential helper to v0.9.0 #1096

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

Kern--
Copy link
Contributor

@Kern-- Kern-- commented Sep 17, 2024

Issue #, if available:
Part of #868

Description of changes:
This change updates the version of the Amazon ECR cred helper to v0.9.0

Testing done:

  1. I ran the credential helper binary test
  2. I started a VM and verified the version of the cred helper
  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Kern Walster <walster@amazon.com>
@pendo324
Copy link
Member

The "required test" rules have changed after the recent addition of Linux. I re-ran the failing tests from the old set of required tests, and I think we can just override + merge after they pass since the behavior is still being tested (the test names just don't match)

@pendo324 pendo324 merged commit 3c98320 into runfinch:main Sep 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants