Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps): bump node-fetch from 2.6.7 to 3.3.2 (#359)" #380

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

austinvazquez
Copy link
Member

Issue #, if available:
N/A

Description of changes:
This reverts commit da35ca9.

The node-fetch dependency update is causing some issues in the backend AWS CodePipeline for Finch infrastructure. Revert the dependency update to unblock pipeline and have follow-up action items for addressing gaps between dependency update workflows and backend pipeline.

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This reverts commit da35ca9.

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@austinvazquez austinvazquez marked this pull request as ready for review August 22, 2023 20:52
@weikequ
Copy link
Contributor

weikequ commented Aug 22, 2023

So the blocked pipeline isn't necessarily that big of a deal as our infra is already deployed. Do you think this would be a big undertaking to investigate+fix root cause?

@austinvazquez
Copy link
Member Author

So the blocked pipeline isn't necessarily that big of a deal as our infra is already deployed. Do you think this would be a big undertaking to investigate+fix root cause?

It is a fair question. I am a little biased because I pushed the update through and don't want to be the one blocking the pipeline. 😅

It is a little difficult to gauge; I am still coming up to speed on this system and not very familiar with with Node development. What are your thoughts towards effort here based on your experience with the infrastructure?

@weikequ
Copy link
Contributor

weikequ commented Aug 22, 2023

Could be related to this: node-fetch/node-fetch#1657. I don't think this issue has anything to do with the actual CDK code itself, just some dependencies/type related issue.

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@austinvazquez
Copy link
Member Author

Could be related to this: node-fetch/node-fetch#1657. I don't think this issue has anything to do with the actual CDK code itself, just some dependencies/type related issue.

Agreed. Issue appears to be with upstream package. I have also expanded the GitHub Actions CI workflow to run npm run build so we only get updates which build.

@austinvazquez austinvazquez merged commit d9453f4 into runfinch:main Aug 23, 2023
2 checks passed
@austinvazquez austinvazquez deleted the revert-da35ca9 branch August 23, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants