Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure in nom_recipes doc tests #1772

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

rlee287
Copy link
Contributor

@rlee287 rlee287 commented Jul 30, 2024

Test failures occurred due to Parser trait changes and updates to delimited signature, with the ws recipe not having been updated accordingly.

Test failures occured due to Parser trait changes and updates to delimited signature, with some recipes not having been updated accordingly
@rlee287 rlee287 requested a review from Geal as a code owner July 30, 2024 01:30
Copy link

codspeed-hq bot commented Aug 4, 2024

CodSpeed Performance Report

Merging #1772 will degrade performances by 19.3%

Comparing rlee287:fix_recipies (2863417) with main (561fb6b)

Summary

❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main rlee287:fix_recipies Change
number 121.9 ns 151.1 ns -19.3%

@Geal Geal merged commit 29c48cc into rust-bakery:main Aug 4, 2024
16 of 17 checks passed
@Geal
Copy link
Collaborator

Geal commented Aug 4, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants