fix(yansi): Handle Bright foreground colors as bold #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtriplett
force-pushed
the
yansi-bright
branch
from
2fb7c96
to
a8bdb1e
Compare
|
Could you add more detail for why this is needed? |
|
@epage Right now, the "Bright" distinction is just ignored and they're folded into the same colors. But "bright" (e.g. "bright blue"), as far as I can tell historically, is a synonym for "bold" (e.g. "bold blue"). https://en.wikipedia.org/wiki/ANSI_escape_code#3-bit_and_4-bit |
joshtriplett
force-pushed
the
yansi-bright
branch
from
a8bdb1e
to
a99bb31
Compare
|
Updated the commit message with that information. |
epage
changed the title
epage
changed the title
The "Bright" distinction was previously ignored, and the bright colors folded into the same colors as the non-bright. But "bright" (e.g. "bright blue"), as far as I can tell historically, is a synonym for "bold" (e.g. "bold blue"). See https://en.wikipedia.org/wiki/ANSI_escape_code#3-bit_and_4-bit for more information.
joshtriplett
force-pushed
the
yansi-bright
branch
from
a99bb31
to
ab3e25a
Compare
Merged
epage
added a commit
to epage/anstyle
that referenced
this pull request
Mar 28, 2024
…on-5.x chore(deps): update actions/setup-python action to v5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the "Bright" distinction is just ignored and they're folded into the same colors. But "bright" (e.g. "bright blue"), as far as I can tell historically, is a synonym for "bold" (e.g. "bold blue").
https://en.wikipedia.org/wiki/ANSI_escape_code#3-bit_and_4-bit