-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASM Automatic Demo Generator Proof of Concept #500
WASM Automatic Demo Generator Proof of Concept #500
Conversation
Not really possible iwith how Javascript works
Causes some dart generation issues if set the other way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Code could be a bit more organized, evaluate_param
is kinda large and clunky
Fine to do all fixes in a followup. |
Moving functions into more easily documentable methods, updating documentation all around
tool/src/js/formatter.rs
Outdated
@@ -44,7 +44,7 @@ const RESERVED: &[&str] = &[ | |||
]; | |||
|
|||
/// Helper class for us to format JS identifiers from the HIR. | |||
pub(super) struct JSFormatter<'tcx> { | |||
pub struct JSFormatter<'tcx> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe?
pub struct JSFormatter<'tcx> { | |
pub(crate) struct JSFormatter<'tcx> { |
tool/src/js/mod.rs
Outdated
@@ -15,13 +15,13 @@ use type_generation::TyGenContext; | |||
mod layout; | |||
|
|||
/// Since the main difference between .mjs and .d.ts is typing, we just want a differentiator for our various helper functions as to what's being generated: .d.ts, or .mjs? | |||
enum FileType { | |||
pub enum FileType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub(crate)
?
Rough implementation of the process described in https://docs.google.com/document/d/1xRTmK0YtOfuAe7ClN6kqDaHyv5HpdIRIYQW6Zc_KKFU/edit?usp=sharing
Proof of concept is live at https://ambiguous.name/diplomat/