Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component is now named 'llvm-tools' #140

Merged
merged 1 commit into from
Dec 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
run: |
rustup toolchain install ${{ matrix.rust }} --profile minimal
rustup default ${{ matrix.rust }}
rustup component add llvm-tools-preview clippy rustfmt
rustup component add llvm-tools clippy rustfmt
echo "::add-matcher::.github/workflows/rust.json"

- name: Clippy
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

- The `llvm-tools-preview` component was renamed to `llvm-tools`

### Changed

- MSRV Changed to 1.70.0
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ This project is developed and maintained by the [Embedded WG Tools team][team].
``` console
$ cargo install cargo-binutils

$ rustup component add llvm-tools-preview
$ rustup component add llvm-tools
```

## Usage
Expand All @@ -35,7 +35,7 @@ $ $(find $(rustc --print sysroot) -name llvm-$tool) ${args[@]}
```

Apart from these `rust-*` tools, which are direct proxies for the llvm tools in
the `llvm-tools-preview` component, the crate also provides some Cargo
the `llvm-tools` component, the crate also provides some Cargo
subcommands that will first build the project and then run the llvm tool on the
output artifact. This:

Expand Down Expand Up @@ -71,7 +71,7 @@ artifact be automatically passed to the LLVM tool. This mode only works when the
subcommand is used from within a Cargo project.

*Disclaimer* Note that `cargo-binutils` simply proxies the LLVM tools in the
`llvm-tools-preview` component and the Rust project makes no guarantee about the
`llvm-tools` component and the Rust project makes no guarantee about the
availability and the CLI of these tools -- i.e. the availability and CLI of
these tools may change as new Rust releases are made.

Expand Down
6 changes: 5 additions & 1 deletion src/tool.rs
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ impl Tool {
};

if !path.exists() {
eprintln!("Could not find tool: {}\nat: {}\nConsider `rustup component add llvm-tools-preview`", self.name(), path.to_string_lossy());
eprintln!(
"Could not find tool: {}\nat: {}\nConsider `rustup component add llvm-tools`",
self.name(),
path.to_string_lossy()
);
process::exit(102)
};

Expand Down