Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is nomem a correct option for isb, dsb and dmb? #502

Closed
evading opened this issue Dec 14, 2023 · 1 comment · Fixed by #526
Closed

Is nomem a correct option for isb, dsb and dmb? #502

evading opened this issue Dec 14, 2023 · 1 comment · Fixed by #526

Comments

@evading
Copy link

evading commented Dec 14, 2023

In the nightly reference for inline assembly it says for nomem that: "The compiler also assumes that this asm! block does not perform any kind of synchronization with other threads, e.g. via fences."
The same wording is not in the stable docs but I don't know if it is only added due to doc update or if there is an actual difference in how the compiler works.
Should those fences have the nomem option set?

@adamgreig
Copy link
Member

Thanks for reporting this. It does look like those methods should not have nomem set, and we should backport the fix to the 0.7 branch too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants