Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct cfg for cm7 feature #518

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Use correct cfg for cm7 feature #518

merged 1 commit into from
Mar 23, 2024

Conversation

Almeida-Oco
Copy link
Contributor

Fixes #517.

Change all occurrences of #[cfg(cm7)] into #[cfg(feature = "cm7")] so the code sections are actually accessible with the cm7 feature.

@Almeida-Oco Almeida-Oco requested a review from a team as a code owner March 23, 2024 09:18
adamgreig
adamgreig approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching and fixing this!

@adamgreig adamgreig added this pull request to the merge queue Mar 23, 2024
Merged via the queue into rust-embedded:master with commit d85d9c8 Mar 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect usage of cm7 feature
2 participants
@Almeida-Oco @adamgreig