Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed used and free methods on CortexMHeap #37

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Exposed used and free methods on CortexMHeap #37

merged 1 commit into from
Jul 13, 2020

Conversation

VictorKoenders
Copy link
Contributor

Added two methods that expose existing functions on the Heap:

The functions should be generic enough that it doesn't pin alloc-cortex-m to a specific implementation. This is the reason the documentation mentions that the methods return an "estimate", as future implementations might not be accurate.

@VictorKoenders VictorKoenders requested a review from a team as a code owner July 13, 2020 11:28
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonas-schievink (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 13, 2020

Build succeeded:

@bors bors bot merged commit 4673f93 into rust-embedded:master Jul 13, 2020
@VictorKoenders VictorKoenders deleted the expose_stats branch July 13, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants