Const generics port #198

korken89 · 2021-03-26T11:50:35Z

Closes #158
Closes #168
Closes #207
Closes #115

I assume there's no reason that only multi-core Producers are marked Send, while Consumers are not (they're pretty symmetrical).

This change allows the create custom structs with size arguments outside the heapless crate itself.

on cortex m0 `%` is extremely costly

vec passes tests vec passes tests with docs as well (besides one with FromIter) vec passes tests with docs as well (besides one with FromIter) exposing full API passing all current tests starting with string string test passes mostly string test passes ufmt passes TODO removed binary_heap wip binary_heap passes tests sealed passes spsc wip spsc wip2 split wip3 spcs and split passes --lib tests spcs and split passes --lib tests spcs and split passes --lib tests spcs and split passes all tests (doc + lib) indexmap wip indexmap passes --lib test indexmap passes all tests (lib + doc) indexset passes all tests (lib + doc) indexset passes all tests (lib + doc) linear map wip linear map all test (lib + doc) passes, drop not tested, into_iter(mut self) not implemented history buffer all test pass (doc + lib), Copy instead of clone atm serde does not work pool works, serde still not serde wip serde wip serde wip serde wip

kpp · 2021-03-28T08:09:48Z

Hey, there are several fixes for this PR: #199. All tests with const generics passed successfully.

Fix several issues in const generics

Fix cfail tests in const generics

src/spsc/mod.rs

src/spsc/split.rs

Simplify code in histbuf for const generics

AfoHT

Much cleaner with consts support 👍

src/histbuf.rs

src/sealed.rs

Sympatron · 2021-04-08T15:43:00Z

Why are spsc::Queue::u8() and spsc::Queue::u16() unsafe now?

korken89 · 2021-04-08T15:50:59Z

@Sympatron The docs state (for Queue::u16()): "Creates an empty queue with a fixed capacity of N. Safety: Assumes N <= u16::MAX.

More or less, we cannot check in const context if N is within the limit of the index.

burrbull · 2021-04-08T15:55:40Z

We can generate safe constructors for limited range of N with macro.

korken89 · 2021-04-08T16:04:29Z

@burrbull How? Const asserts are not allowed to be used with const generics for now.

burrbull · 2021-04-08T17:20:22Z

See #205

src/indexmap.rs

src/histbuf.rs

burrbull · 2021-04-18T15:52:15Z

Is this mean you've decided to use atomic usize everywhere?

korken89 · 2021-04-18T16:02:01Z

@burrbull Yes, the implementation that existed was not easily amendable to the fix of #207, and the known good implementation performs very well.
The key here is simplicity, easy to check for correctness - where the old implementation was unfortunately not.

So for now I'll remove the support for smaller queue indexes, and we can reintroduce them in the future if necessary.

This commit implements a new, simplified, SPSC that does not have the reported issues (e.g. not properly wrapping the indexes for non powers-of-2), and the support for multiple different index sizes has been removed for simplicity.

CHANGELOG.md

japaric and others added 17 commits March 25, 2021 16:30

x86_64: "practically" thread-safe Pool

e4580da

fix warnings

596a1f0

x86: put Sync impl behind a Cargo feature

b9d7128

1.36.0 compatibility

b0129f5

Preparing for v0.5.5

357a312

Make Producer<..., SingleCore> Send, like Consumer

87917e0

I assume there's no reason that only multi-core Producers are marked Send, while Consumers are not (they're pretty symmetrical).

indexmap: expose PowerOfTwo, Bucket and Pos

1790c4f

This change allows the create custom structs with size arguments outside the heapless crate itself.

readme: add instructions for tests

0ab806d

histbuf: replace slow modulo operatins

26dcfa3

on cortex m0 `%` is extremely costly

histbuf: fix style

9e08514

Vec: add set_len

0364e05

String: add as_mut_vec

6ba462e

Fixes for min const generics

6dcedb8

Merge branch 'master' into const_generics

8ba71d4

Fixed warnings

305de71

Cleanup

3de878b

korken89 marked this pull request as draft March 26, 2021 11:50

kpp added 5 commits March 28, 2021 09:48

Fix fmt

f7cb3e5

Update minimal Rust version from 1.31 to 1.51

a3f4d8f

Fix cargo test without cargo features enabled

92cc062

Fix warnings in src/indexmap.rs

7fb276f

Fix cfail tests

5bde47c

korken89 added 3 commits March 30, 2021 17:15

Merge pull request #199 from kpp/const_generics

aee0817

Fix several issues in const generics

Cleanup and HistoryBuffer is now const and using MaybeUninit

1444990

Merge branch 'master' into const_generics

73d209a

korken89 marked this pull request as ready for review April 1, 2021 17:17

Removed unnecessary String interface, already covered by core

12682bd

korken89 force-pushed the const_generics branch from 831394f to 688890d Compare April 1, 2021 18:52

Merge pull request #202 from kpp/fix_cfail

5d294a7

Fix cfail tests in const generics

kpp reviewed Apr 3, 2021

View reviewed changes

src/spsc/mod.rs Show resolved Hide resolved

kpp reviewed Apr 3, 2021

View reviewed changes

src/spsc/mod.rs Outdated Show resolved Hide resolved

src/spsc/split.rs Outdated Show resolved Hide resolved

kpp and others added 3 commits April 3, 2021 22:20

Simplify code in histbuf

6bee0f8

Merge pull request #203 from kpp/simplify_histbuf

e21c402

Simplify code in histbuf for const generics

Restore tests for SPSC as close as we can

2bfe3fe

korken89 force-pushed the const_generics branch from c1e0a00 to 2bfe3fe Compare April 4, 2021 10:12

korken89 added 2 commits April 4, 2021 12:55

Added unsafe and docs to Queue::{u8(), u16()}

1fac593

Fixed so pool and MPMC works on thumbv6

2c248a3

AfoHT reviewed Apr 7, 2021

View reviewed changes

src/histbuf.rs Show resolved Hide resolved

src/sealed.rs Outdated Show resolved Hide resolved

korken89 added 2 commits April 8, 2021 12:05

Cleanup of comments

0ffef8f

Updated changelog

dfa5d50

MabezDev reviewed Apr 12, 2021

View reviewed changes

src/indexmap.rs Outdated Show resolved Hide resolved

birkenfeld reviewed Apr 12, 2021

View reviewed changes

src/histbuf.rs Outdated Show resolved Hide resolved

New SPSC queue, now safe and much simpler

6fdcc4f

This commit implements a new, simplified, SPSC that does not have the reported issues (e.g. not properly wrapping the indexes for non powers-of-2), and the support for multiple different index sizes has been removed for simplicity.

korken89 force-pushed the const_generics branch from ce83c8d to 6fdcc4f Compare April 18, 2021 17:19

IndexMap::new() is now a const-fn

58cb279

korken89 force-pushed the const_generics branch from deaa3be to 58cb279 Compare April 19, 2021 19:36

Clarification in changelog

bf6728e

Sympatron reviewed Apr 20, 2021

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

Added missing {enqueue, dequeue}_unchecked interfaces

8754c3d

korken89 merged commit bd32ab8 into master Apr 22, 2021

korken89 deleted the const_generics branch April 22, 2021 17:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Const generics port #198

Const generics port #198

korken89 commented Mar 26, 2021 •

edited

Loading

kpp commented Mar 28, 2021

AfoHT left a comment

Sympatron commented Apr 8, 2021

korken89 commented Apr 8, 2021

burrbull commented Apr 8, 2021

korken89 commented Apr 8, 2021

burrbull commented Apr 8, 2021

burrbull commented Apr 18, 2021

korken89 commented Apr 18, 2021

Const generics port #198

Const generics port #198

Conversation

korken89 commented Mar 26, 2021 • edited Loading

kpp commented Mar 28, 2021

AfoHT left a comment

Choose a reason for hiding this comment

Sympatron commented Apr 8, 2021

korken89 commented Apr 8, 2021

burrbull commented Apr 8, 2021

korken89 commented Apr 8, 2021

burrbull commented Apr 8, 2021

burrbull commented Apr 18, 2021

korken89 commented Apr 18, 2021

korken89 commented Mar 26, 2021 •

edited

Loading