-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raw_access #841
base: master
Are you sure you want to change the base?
raw_access #841
Conversation
I'm not sure if there's any advantage to skipping volatile_cell but still having the registers be themselves memory-mapped (with &self cast to a pointer). We still have the problem that Rust can dereference &self and perform an invalid read. Probably we have to do something similar to chiptool where the peripheral struct owns a pointer and the register methods offset it - the total memory cost is the same because instead of having reference-to-a-ZST like now, we would have an owned-pointer. It might be hard to do this and keep vcell too, but maybe we can just remove vcell support at the same time? |
904b44e
to
a816243
Compare
It is not hard. Review yet one time, please.
|
/ci diff pr |
/ci diff pr --current " --raw-access" |
Diff for comment |
/ci diff pr |
/ci diff pr --current " --raw-access" |
Diff for comment |
rebased on #847 |
Related to rust-embedded/wg#791
cc @adamgreig