Skip to content

Commit

Permalink
Auto merge of rust-lang#116391 - Nadrieril:constructorset, r=<try>
Browse files Browse the repository at this point in the history
exhaustiveness: Rework constructor splitting

`SplitWildcard` was pretty opaque. I replaced it with a more legible abstraction: `ConstructorSet` represents the set of constructors for patterns of a given type. This clarifies responsibilities: `ConstructorSet` handles one clear task, and diagnostic-related shenanigans can be done separately.

I'm quite excited, I had has this in mind for years but could never quite introduce it. This opens up possibilities, including type-specific optimisations (like using a `FxHashSet` to collect enum variants, which had been [hackily attempted some years ago](rust-lang#76918)), my one-pass rewrite (rust-lang#116042), and future librarification.
  • Loading branch information
bors committed Oct 3, 2023
2 parents e3c631b + fda0301 commit 48efd89
Show file tree
Hide file tree
Showing 2 changed files with 645 additions and 582 deletions.
Loading

0 comments on commit 48efd89

Please sign in to comment.