-
Notifications
You must be signed in to change notification settings - Fork 245
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Correctly handle spaces in /proc/pid/maps pathnames (#553)
Prior to this change, pathnames were parsed from `/proc/pid/maps` using `s.split(' ')`. This is incorrect, because pathnames may contain spaces. In practice, on the relevant operating systems, this resulted in truncation of pathnames containing spaces. This lead to a failure resolve any symbols or offsets, which in turn causes the stack trace to be printed containing only `<unknown>`s to the end user. This PR corrects the parsing code, resolving the issue.
- Loading branch information
Showing
1 changed file
with
72 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters