Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update other GitHub actions #669

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Update other GitHub actions #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97ec052
Use actions/upload-artifact@v4.1.7
workingjubilee Sep 14, 2024
73107a8
Use actions/checkout@v4
workingjubilee Sep 14, 2024
99d7d4c
Use an improbably large change-id
workingjubilee Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/check-binary-size.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ jobs:
# patched in to std. It's cloned here to access the Github action for
# building and measuring the test binary.
- name: Clone backtrace to access Github action
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
path: ${{ env.BACKTRACE_DIR }}
- name: Clone Rustc
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: rust-lang/rust
path: ${{ env.RUSTC_DIR }}
Expand All @@ -61,6 +61,7 @@ jobs:
run: |
# Bootstrap config
cat <<EOF > config.toml
change-id = 9999999
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to have worked? Maybe it's not seeing the config.toml file for some reason?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also using actions/checkout@v3. It won't use the workflow file changes until they're merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see! I get what you were saying now. This looks right to me so I guess we'll merge and see?

[llvm]
download-ci-llvm = true
[rust]
Expand Down Expand Up @@ -126,7 +127,7 @@ jobs:
{ flag: "wx" },
);
- name: Upload size data
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4.1.7
with:
name: size-files
path: ${{ env.SIZE_DATA_DIR }}/${{ env.SIZE_DATA_FILE }}
Expand All @@ -140,7 +141,7 @@ jobs:
pull-requests: write
steps:
# Clone backtrace to access Github composite actions to report size.
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Download size data
uses: actions/download-artifact@v4.1.7
with:
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- os: windows-latest
rust: nightly-x86_64-gnu
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: Install Rust (rustup)
Expand Down Expand Up @@ -133,7 +133,7 @@ jobs:
name: Windows AArch64
runs-on: windows-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: Install Rust
Expand All @@ -155,7 +155,7 @@ jobs:
- target: x86_64-apple-ios
sdk: iphonesimulator
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- run: rustup target add ${{ matrix.target }}
Expand Down Expand Up @@ -189,7 +189,7 @@ jobs:
- i686-linux-android
- x86_64-linux-android
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: Install Rust
Expand All @@ -204,7 +204,7 @@ jobs:
name: Rustfmt
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: Install Rust
Expand All @@ -223,7 +223,7 @@ jobs:
- x86_64-fortanix-unknown-sgx
- x86_64-unknown-illumos
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: Install Rust
Expand All @@ -244,7 +244,7 @@ jobs:
- os: ubuntu-20.04
- os: windows-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: Install Rust
Expand All @@ -255,7 +255,7 @@ jobs:
name: Miri
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: Install Miri
Expand Down
Loading