Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.73 announcement #1149

Merged
merged 4 commits into from
Oct 5, 2023
Merged

1.73 announcement #1149

merged 4 commits into from
Oct 5, 2023

Conversation

Mark-Simulacrum
Copy link
Member

cc @rust-lang/release

Co-authored-by: Eric Huss <eric@huss.org>
Co-authored-by: Josh Stone <cuviper@gmail.com>
Co-authored-by: Nathan Stocks <cleancut@github.com>
@Mark-Simulacrum Mark-Simulacrum merged commit d918287 into rust-lang:master Oct 5, 2023
2 checks passed
- [Unsigned `{integer}::div_ceil`](https://doc.rust-lang.org/stable/std/primitive.u32.html#method.div_ceil)
- [Unsigned `{integer}::next_multiple_of`](https://doc.rust-lang.org/stable/std/primitive.u32.html#method.next_multiple_of)
- [Unsigned `{integer}::checked_next_multiple_of`](https://doc.rust-lang.org/stable/std/primitive.u32.html#method.checked_next_multiple_of)
- [`std::ffi::FromBytesUntilNulError`](https://doc.rust-lang.org/stable/std/ffi/struct.FromBytesUntilNulError.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is FromBytesUntilNulError on this list? It has been stable since 1.69 [source] [1.69 blog post]. Was there something else that was supposed to be listed instead of this?

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. @cuviper do you remember anything about why you added this?

Copy link
Member

@cuviper cuviper Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was only in core::ffi before, forgotten to re-export from std::ffi until now. Compare:

Copy link
Contributor

@ehuss ehuss Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was stabilized in 1.69 as core::ffi::FromBytesUntilNulError (notice the "core"), but was mistakenly not re-exported in std. 1.73 fixed that so that it is now available as std::ffi::FromBytesUntilNulError, and thus it is "new" at that location.

EDIT: Jinx! 😝

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhhh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants