Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition rustc-guide to rustc-dev-guide #535

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Transition rustc-guide to rustc-dev-guide #535

merged 3 commits into from
Mar 10, 2020

Conversation

chrissimpkins
Copy link
Member

The rustc-guide is being renamed to the rustc-dev-guide. The discussion is in rust-lang/rustc-dev-guide#470.

This PR revises rustc-guide, rustc guide, and Rustc Guide to the new names.

Transition tracker: rust-lang/rustc-dev-guide#602

@chrissimpkins chrissimpkins mentioned this pull request Mar 6, 2020
Closed
28 tasks
LeSeulArtichaut
LeSeulArtichaut approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't spotted any mistake, proposed few nitpicks.

posts/2018-05-15-Rust-turns-three.md Outdated Show resolved Hide resolved
posts/inside-rust/2019-10-15-compiler-team-meeting.md Outdated Show resolved Hide resolved
posts/inside-rust/2019-11-07-compiler-team-meeting.md Outdated Show resolved Hide resolved
@chrissimpkins
Copy link
Member Author

chrissimpkins commented Mar 6, 2020 •
edited
Loading

Thank you @LeSeulArtichaut! I will address all of these recommendations with changes. Much appreciated

mark-i-m
mark-i-m approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chrissimpkins chrissimpkins changed the title [Do not merge yet] Transition rustc-guide to rustc-dev-guide Transition rustc-guide to rustc-dev-guide Mar 9, 2020
@chrissimpkins
Copy link
Member Author

Ready for merge!

@Mark-Simulacrum Mark-Simulacrum merged commit 2dca227 into rust-lang:master Mar 10, 2020
@chrissimpkins chrissimpkins deleted the rustc-dev-guide-transition branch March 26, 2020 02:34
steveklabnik pushed a commit that referenced this pull request Mar 27, 2020
@chrissimpkins @steveklabnik
Transition rustc-guide to rustc-dev-guide (#535)
44c87f9 
See also rust-lang/rustc-dev-guide#602.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-i-m mark-i-m mark-i-m approved these changes

@LeSeulArtichaut LeSeulArtichaut LeSeulArtichaut approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrissimpkins @mark-i-m @LeSeulArtichaut @nikomatsakis @Mark-Simulacrum