-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Windows install instructions #2389
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,11 +53,11 @@ On Windows, go to [https://www.rust-lang.org/tools/install][install] and follow | |
the instructions for installing Rust. At some point in the installation, you’ll | ||
receive a message explaining that you’ll also need the C++ build tools for | ||
Visual Studio 2013 or later. The easiest way to acquire the build tools is to | ||
install [Build Tools for Visual Studio 2019][visualstudio]. The tools are in | ||
the Other Tools and Frameworks section. | ||
install [Build Tools for Visual Studio 2019][visualstudio]. When asked which | ||
workloads to install make sure "C++ build tools" is selected and that the Windows 10 SDK and the English language pack components are included. | ||
|
||
[install]: https://www.rust-lang.org/tools/install | ||
[visualstudio]: https://www.visualstudio.com/downloads/#build-tools-for-visual-studio-2019 | ||
[visualstudio]: https://visualstudio.microsoft.com/visual-cpp-build-tools/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ah this is great, thanks! |
||
|
||
The rest of this book uses commands that work in both *cmd.exe* and PowerShell. | ||
If there are specific differences, we’ll explain which to use. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the English language pack bit actually required? What for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure but I lifted the instructions direct from rustup. It seems there are issue with handling non-English output from
link.exe
. See here and here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having discussed this elsewhere it seems being English only is an explicit design choice, which also has the side-effect of avoiding the encoding complexity.
So long story short, yes the English language pack is required.