Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore proper error for crate not in local reg #10683

Merged
merged 1 commit into from
May 23, 2022
Merged

Restore proper error for crate not in local reg #10683

merged 1 commit into from
May 23, 2022

Conversation

jonhoo
Copy link
Contributor

@jonhoo jonhoo commented May 20, 2022

Fixes #10682.

@rust-highfive
Copy link

r? @ehuss

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 20, 2022
@jonhoo jonhoo mentioned this pull request May 20, 2022
Closed
Eh2406
Eh2406 approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@Eh2406 Eh2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@arlosi
Copy link
Contributor

arlosi commented May 20, 2022

Thanks! This looks like the right fix to me.

@ehuss
Copy link
Contributor

ehuss commented May 23, 2022

@bors r=Eh2406

@bors
Copy link
Collaborator

bors commented May 23, 2022

📌 Commit c262f10 has been approved by Eh2406

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2022
@bors
Copy link
Collaborator

bors commented May 23, 2022

⌛ Testing commit c262f10 with merge 11d4599...

@bors
Copy link
Collaborator

bors commented May 23, 2022

☀️ Test successful - checks-actions
Approved by: Eh2406
Pushing 11d4599 to master...

@bors bors merged commit 11d4599 into rust-lang:master May 23, 2022
@arlosi arlosi mentioned this pull request May 25, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2022
@bors
Auto merge of rust-lang#97403 - arlosi:update-cargo, r=ehuss
4cbaac6 
Update cargo

10 commits in a4c1cd0eb6b18082a7e693f5a665548fe1534be4..39ad1039d9e3e1746177bf5d134af4c164f95528
2022-05-20 00:55:25 +0000 to 2022-05-25 00:50:02 +0000

* doc: discuss build script instruction order (rust-lang/cargo#10600)
* Require http-registry URLs to end with a '/' (rust-lang/cargo#10698)
* No printing executable names when running tests and benchmarks with json message format (rust-lang/cargo#10691)
* Restore proper error for crate not in local reg (rust-lang/cargo#10683)
* Update libcurl (rust-lang/cargo#10696)
* Fixed small typos (rust-lang/cargo#10693)
* fix bugs with `workspace` key and `update_toml` (rust-lang/cargo#10685)
* Bump to 0.64.0, update changelog (rust-lang/cargo#10687)
* List C compiler as a build dependency in README (rust-lang/cargo#10678)
* Add unstable `rustc-check-cfg` build script output (rust-lang/cargo#10539)

r? `@ehuss`
@jonhoo jonhoo deleted the fix-10682 branch May 26, 2022 16:37
@ehuss ehuss added this to the 1.63.0 milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eh2406 Eh2406 Eh2406 approved these changes

Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

Regression in 1.61 error message for crate not found in local registry
6 participants
@jonhoo @rust-highfive @arlosi @ehuss @bors @Eh2406