Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify config to use vendored source is printed to stdout #12893

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

#7280 states out it not clear how to get the necessary config for cargo vendor.
This PR improves the documentation a bit but hasn't yet resolved the issue that --quiet makes cargo vendor stdout really quiet.

How should we test and review this PR?

mdbook serve src/doc and read the doc.

Additional information

@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2023
@epage epage closed this Oct 30, 2023
@epage epage reopened this Oct 30, 2023
@epage
Copy link
Contributor

epage commented Oct 30, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 30, 2023

📌 Commit 9013f0a has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2023
@bors
Copy link
Collaborator

bors commented Oct 30, 2023

⌛ Testing commit 9013f0a with merge b988daa...

@bors
Copy link
Collaborator

bors commented Oct 30, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing b988daa to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Oct 30, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing b988daa to master...

@bors bors merged commit b988daa into rust-lang:master Oct 30, 2023
39 checks passed
@bors
Copy link
Collaborator

bors commented Oct 30, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2023
Update cargo

7 commits in 708383d620e183a9ece69b8fe930c411d83dee27..b4d18d4bd3db6d872892f6c87c51a02999b80802
2023-10-27 21:09:26 +0000 to 2023-10-31 18:19:10 +0000
- refactor(toml): Cleanup noticed on the way to rust-lang/cargo#12801 (rust-lang/cargo#12902)
- feat(trim-paths): set env `CARGO_TRIM_PATHS` for build scripts (rust-lang/cargo#12900)
- feat: implement RFC 3127 `-Ztrim-paths` (rust-lang/cargo#12625)
- docs: clarify config to use vendored source is printed to stdout (rust-lang/cargo#12893)
- Improve the margin calculation for the search command's UI (rust-lang/cargo#12890)
- Add new packages to [workspace.members] automatically (rust-lang/cargo#12779)
- refactor(toml): Decouple parsing from interning system (rust-lang/cargo#12881)

r? ghost
@ehuss ehuss added this to the 1.75.0 milestone Nov 6, 2023
@weihanglo weihanglo deleted the vendor-doc branch November 28, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants