Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(resolver): Consolidate logic in VersionPreferences #12930

Merged
merged 6 commits into from
Nov 10, 2023
Merged

refactor(resolver): Consolidate logic in VersionPreferences #12930

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3cdddbf
test(resolver): Improve failure output
epage Nov 8, 2023
bf2987b
refactor(resolver): Track minimal-versions in VersionPreferences
epage Nov 7, 2023
6bfc32a
refactor(resolver): Pull MSRV handling to VersionPreferences
epage Nov 7, 2023
0f1c9df
test(resolver): Add MSRV pref test
epage Nov 7, 2023
1b10550
refactor(resolver): Allow scaling number of sort cases
epage Nov 7, 2023
46bb8ee
docs(cargo): Clarify sort_summaries behavior
epage Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test(resolver): Improve failure output
  • Loading branch information
@epage
epage committed Nov 8, 2023
commit 3cdddbf033c0066ca2e0b8df2c2fbdbd1c5334f7
11 changes: 7 additions & 4 deletions crates/resolver-tests/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,14 +982,17 @@ fn meta_test_multiple_versions_strategy() {

/// Assert `xs` contains `elems`
#[track_caller]
pub fn assert_contains<A: PartialEq>(xs: &[A], elems: &[A]) {
pub fn assert_contains<A: PartialEq + std::fmt::Debug>(xs: &[A], elems: &[A]) {
for elem in elems {
assert!(xs.contains(elem));
assert!(
xs.contains(elem),
"missing element\nset: {xs:?}\nmissing: {elem:?}"
);
}
}

#[track_caller]
pub fn assert_same<A: PartialEq>(a: &[A], b: &[A]) {
assert_eq!(a.len(), b.len());
pub fn assert_same<A: PartialEq + std::fmt::Debug>(a: &[A], b: &[A]) {
assert_eq!(a.len(), b.len(), "not equal\n{a:?}\n{b:?}");
assert_contains(b, a);
}