Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Clarify more Config -> Context #13506

Merged
merged 3 commits into from
Mar 1, 2024
Merged

refactor: Clarify more Config -> Context #13506

merged 3 commits into from
Mar 1, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented Feb 29, 2024

What does this PR try to resolve?

This is a follow up to #13409 and #13486

How should we test and review this PR?

Additional information

@rustbot
Copy link
Collaborator

rustbot commented Feb 29, 2024

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler A-cfg-expr Area: Platform cfg expressions A-cli Area: Command-line interface, option parsing, etc. A-console-output Area: Terminal output, colors, progress bar, etc. A-dependency-resolution Area: dependency resolution and the resolver A-git Area: anything dealing with git A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-interacts-with-crates.io Area: interaction with registries A-manifest Area: Cargo.toml issues A-networking Area: networking issues, curl, etc. A-profiles Area: profiles A-registry-authentication Area: registry authentication and authorization (authn authz) A-unstable Area: nightly unstable support A-workspaces Area: workspaces Command-doc Command-fetch Command-generate-lockfile Command-package Command-publish Command-yank S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 29, 2024
@weihanglo
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Mar 1, 2024

📌 Commit a7ba26b has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2024
@bors
Copy link
Collaborator

bors commented Mar 1, 2024

⌛ Testing commit a7ba26b with merge ea22fe5...

@bors
Copy link
Collaborator

bors commented Mar 1, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing ea22fe5 to master...

@bors bors merged commit ea22fe5 into rust-lang:master Mar 1, 2024
21 checks passed
@epage epage deleted the context branch March 1, 2024 14:38
@weihanglo weihanglo mentioned this pull request Mar 2, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 2, 2024
@bors
Auto merge of rust-lang#121878 - weihanglo:update-cargo, r=weihanglo
1dc5f73 
Update cargo

12 commits in 8964c8ccff6e420e2a38b8696d178d69fab84d9d..f772ec0224d3755ce52ac5128a80319fb2eb45d0
2024-02-27 19:22:46 +0000 to 2024-03-01 22:57:35 +0000
- feat(toml): Warn on unset Edition (rust-lang/cargo#13505)
- fix(msrv): Report all incompatible packages, not just a random one (rust-lang/cargo#13514)
- refactor: abstract `std::fs` away from on-disk index cache (rust-lang/cargo#13515)
- chore(deps): update compatible (rust-lang/cargo#13507)
- chore(deps): update rust crate rusqlite to 0.31.0 (rust-lang/cargo#13510)
- [docs]: Clarify vendored sources as read-only and way to modify (rust-lang/cargo#13512)
- chore(deps): update rust crate supports-hyperlinks to v3 (rust-lang/cargo#13511)
- refactor: Clarify more Config -> Context (rust-lang/cargo#13506)
- test: Make `edition` explicit in packages (rust-lang/cargo#13504)
- Add all unit's children recursively for `doc.extern-map` option (rust-lang/cargo#13481)
- fix(rustc): Always pass --edition to rustc (rust-lang/cargo#13499)
- Silently ignore `cargo::rustc-check-cfg` to avoid MSRV annoyance when stabilizing `-Zcheck-cfg` (rust-lang/cargo#13438)

r? ghost
@rustbot rustbot added this to the 1.78.0 milestone Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@weihanglo weihanglo

Labels
A-build-execution Area: anything dealing with executing the compiler A-cfg-expr Area: Platform cfg expressions A-cli Area: Command-line interface, option parsing, etc. A-console-output Area: Terminal output, colors, progress bar, etc. A-dependency-resolution Area: dependency resolution and the resolver A-git Area: anything dealing with git A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-interacts-with-crates.io Area: interaction with registries A-manifest Area: Cargo.toml issues A-networking Area: networking issues, curl, etc. A-profiles Area: profiles A-registry-authentication Area: registry authentication and authorization (authn authz) A-unstable Area: nightly unstable support A-workspaces Area: workspaces Command-doc Command-fetch Command-generate-lockfile Command-package Command-publish Command-yank S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
4 participants
@epage @rustbot @weihanglo @bors