Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing '--extern' usage in build scripts and in config files #14101

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

notdanilo
Copy link

What does this PR try to resolve?

This PR implements #14065, allowing build scripts to automatically set dependencies, an important requirement for codegen tools.

@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler A-build-scripts Area: build.rs scripts S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2024
@notdanilo notdanilo force-pushed the allow-extern-in-build-script-and-config-file branch from f0d365e to 50ae1b2 Compare June 18, 2024 20:02
@epage
Copy link
Contributor

epage commented Jun 18, 2024

Thank you for your enthusiasm in wanting to improve cargo! However, our contribution guidelines say that Issues must be accepted by the cargo team before they will be reviewed

@weihanglo
Copy link
Member

Thanks for the PR. Marked it as draft for now to reflect the fact that it's still in discussion.

@weihanglo weihanglo marked this pull request as draft June 24, 2024 22:55
@bors
Copy link
Collaborator

bors commented Jul 5, 2024

☔ The latest upstream changes (presumably #14193) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-execution Area: anything dealing with executing the compiler A-build-scripts Area: build.rs scripts S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants