test: Migrate lto tests to snapbox #14209

dieterplex · 2024-07-08T04:06:32Z

Part of #14039.

rustbot · 2024-07-08T04:06:36Z

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

dieterplex · 2024-07-08T06:17:39Z

Don't know why it fail twice.

thread 'global_cache_tracker::compatible_with_older_cargo' panicked at tests/testsuite/global_cache_tracker.rs:1987:10:

test failed running `/home/runner/work/cargo/cargo/target/debug/cargo check -Zgc`
error: process exited with code 101 (expected 0)
(...skip...)
thread 'main' panicked at src/cargo/core/compiler/fingerprint/mod.rs:1834:9:
assertion `left == right` failed
  left: "0b455c154b949b0d"
 right: "ce6d4698ea4438f2"

https://github.com/rust-lang/cargo/actions/runs/9833359314/job/27143461910#step:11:4050

epage · 2024-07-08T20:18:43Z

We're discussing that failure at https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/Fingerprint.20assert.20in.20tests

tests/testsuite/lto.rs

dieterplex · 2024-07-09T02:00:57Z

Now it breaks with https://github.com/rust-lang/cargo/actions/runs/9849319357/job/27192808047#step:11:4088


thread 'main' has overflowed its stack
error: could not document `foo`

Caused by:
  process didn't exit successfully: `rustdoc --edition=2015 --crate-type lib --crate-name foo src\lib.rs -o D:\a\cargo\cargo\target\tmp\cit\t1268\foo\target\doc --check-cfg cfg(docsrs) --check-cfg "cfg(feature, values())" --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat -C metadata=10d924ec6a37bdaa -L dependency=D:\a\cargo\cargo\target\tmp\cit\t1268\foo\target\debug\deps --extern a=D:\a\cargo\cargo\target\tmp\cit\t1268\foo\target\debug\deps\liba-afbe6803dac1e694.rmeta --crate-version 0.0.1` (exit code: 0xc00000fd, STATUS_STACK_OVERFLOW)

failures:
    doc::doc_cap_lints

Seems not related to previous fixed error,
should it rerun CI?

weihanglo · 2024-07-09T03:24:23Z

Attached full log here for futurue reference.

---- doc::doc_cap_lints stdout ----
running `D:\a\cargo\cargo\target\debug\cargo.exe doc`
running `D:\a\cargo\cargo\target\debug\cargo.exe doc -vv`
thread 'doc::doc_cap_lints' panicked at tests\testsuite\doc.rs:1872:10:

test failed running `D:\a\cargo\cargo\target\debug\cargo.exe doc -vv`
error: process exited with code 101 (expected 0)
--- stdout

--- stderr
    Checking a v0.5.0 (file:///D:/a/cargo/cargo/target/tmp/cit/t1268/a#6781128e)
 Documenting a v0.5.0 (file:///D:/a/cargo/cargo/target/tmp/cit/t1268/a#6781128e)
     Running `set CARGO=\\?\D:\a\cargo\cargo\target\debug\cargo.exe&& set CARGO_CRATE_NAME=a&& set CARGO_MANIFEST_DIR=D:\a\cargo\cargo\target\tmp\cit\t1268\home\.cargo\git\checkouts\a-8baaf4225d65e0c6\6781128&& set CARGO_PKG_AUTHORS=wycats@example.com&& set CARGO_PKG_DESCRIPTION=""&& set CARGO_PKG_HOMEPAGE=""&& set CARGO_PKG_LICENSE=""&& set CARGO_PKG_LICENSE_FILE=""&& set CARGO_PKG_NAME=a&& set CARGO_PKG_README=""&& set CARGO_PKG_REPOSITORY=""&& set CARGO_PKG_RUST_VERSION=""&& set CARGO_PKG_VERSION=0.5.0&& set CARGO_PKG_VERSION_MAJOR=0&& set CARGO_PKG_VERSION_MINOR=5&& set CARGO_PKG_VERSION_PATCH=0&& set CARGO_PKG_VERSION_PRE=""&& set PATH="D:\a\cargo\cargo\target\tmp\cit\t1268\foo\target\debug\deps;C:\Users\runneradmin\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\bin;D:\a\cargo\cargo\target\debug\build\curl-sys-3cdfc50fd064581e\out\build;D:\a\cargo\cargo\target\debug\build\libgit2-sys-fe666c639a2e07ee\out\build;D:\a\cargo\cargo\target\debug\build\libnghttp2-sys-13fcb8b547fbe868\out\i\lib;D:\a\cargo\cargo\target\debug\build\libsqlite3-sys-37c5e72bff0a7ce3\out;D:\a\cargo\cargo\target\debug\build\libssh2-sys-8856f938628c929f\out\build;D:\a\cargo\cargo\target\debug\build\libz-sys-0d64be973d275c44\out\lib;D:\a\cargo\cargo\target\debug\build\libz-sys-896f62a45e9e91c5\out\lib;D:\a\cargo\cargo\target\debug\deps;D:\a\cargo\cargo\target\debug;C:\Users\runneradmin\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\lib\rustlib\x86_64-pc-windows-gnu\lib;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Users\runneradmin\bin;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS\;C:\tools\zstd;C:\Program Files\Mercurial\;C:\hostedtoolcache\windows\stack\2.15.7\x64;C:\cabal\bin;C:\\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.1\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver\;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.11\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.412-8\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\docker-compose;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\dotnet\;C:\Program Files\PowerShell\7\;C:\Program Files\Microsoft\Web Platform Installer\;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn\;C:\Program Files\Microsoft SQL Server\150\Tools\Binn\;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn\;C:\Program Files\Microsoft SQL Server\140\DTS\Binn\;C:\Program Files\Microsoft SQL Server\150\DTS\Binn\;C:\Program Files\Microsoft SQL Server\160\DTS\Binn\;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.7\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs\;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI\;c:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2\;C:\Program Files\Amazon\SessionManagerPlugin\bin\;C:\Program Files\Amazon\AWSSAMCLI\bin\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps"&& rustc --crate-name a --edition=2015 D:\a\cargo\cargo\target\tmp\cit\t1268\home\.cargo\git\checkouts\a-8baaf4225d65e0c6\6781128\src\lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata -C embed-bitcode=no -C debuginfo=2 --check-cfg cfg(docsrs) --check-cfg "cfg(feature, values())" -C metadata=afbe6803dac1e694 -C extra-filename=-afbe6803dac1e694 --out-dir D:\a\cargo\cargo\target\tmp\cit\t1268\foo\target\debug\deps -L dependency=D:\a\cargo\cargo\target\tmp\cit\t1268\foo\target\debug\deps --cap-lints warn`
     Running `rustdoc --edition=2015 --crate-type lib --crate-name a D:\a\cargo\cargo\target\tmp\cit\t1268\home\.cargo\git\checkouts\a-8baaf4225d65e0c6\6781128\src\lib.rs --cap-lints warn -o D:\a\cargo\cargo\target\tmp\cit\t1268\foo\target\doc --check-cfg cfg(docsrs) --check-cfg "cfg(feature, values())" --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat -C metadata=afbe6803dac1e694 -L dependency=D:\a\cargo\cargo\target\tmp\cit\t1268\foo\target\debug\deps --crate-version 0.5.0`
warning: lint `broken_intra_doc_links` has been renamed to `rustdoc::broken_intra_doc_links`
 --> D:\a\cargo\cargo\target\tmp\cit\t1268\home\.cargo\git\checkouts\a-8baaf4225d65e0c6\6781128\src\lib.rs:2:9
  |
2 | #![deny(broken_intra_doc_links)]
  |         ^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `rustdoc::broken_intra_doc_links`
  |
  = note: `#[warn(renamed_and_removed_lints)]` on by default

warning: unresolved link to `bad_link`
 --> D:\a\cargo\cargo\target\tmp\cit\t1268\home\.cargo\git\checkouts\a-8baaf4225d65e0c6\6781128\src\lib.rs:4:6
  |
4 | /// [bad_link]
  |      ^^^^^^^^ no item named `bad_link` in scope
  |
  = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
note: the lint level is defined here
 --> D:\a\cargo\cargo\target\tmp\cit\t1268\home\.cargo\git\checkouts\a-8baaf4225d65e0c6\6781128\src\lib.rs:2:9
  |
2 | #![deny(broken_intra_doc_links)]
  |         ^^^^^^^^^^^^^^^^^^^^^^

warning: `a` (lib doc) generated 2 warnings
 Documenting foo v0.0.1 (D:\a\cargo\cargo\target\tmp\cit\t1268\foo)
     Running `rustdoc --edition=2015 --crate-type lib --crate-name foo src\lib.rs -o D:\a\cargo\cargo\target\tmp\cit\t1268\foo\target\doc --check-cfg cfg(docsrs) --check-cfg "cfg(feature, values())" --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat -C metadata=10d924ec6a37bdaa -L dependency=D:\a\cargo\cargo\target\tmp\cit\t1268\foo\target\debug\deps --extern a=D:\a\cargo\cargo\target\tmp\cit\t1268\foo\target\debug\deps\liba-afbe6803dac1e694.rmeta --crate-version 0.0.1`

thread 'main' has overflowed its stack
error: could not document `foo`

It doesn't make sense that overflow only happened on Windows GNU.

@bors try

test: Migrate lto tests to snapbox Part of #14039.

bors · 2024-07-09T03:25:30Z

⌛ Trying commit 18d7589 with merge 54fd320...

bors · 2024-07-09T04:00:46Z

☀️ Try build successful - checks-actions
Build commit: 54fd320 (54fd32041d242e464606eabcb2cb3a7fa5cb7fa6)

tests/testsuite/lto.rs

fix: rename to `rustdoc::broken_intra_doc_links` Found in <#14209 (comment)>.

weihanglo · 2024-07-10T18:28:21Z

Thank you for your contribution!

@bors r+

bors · 2024-07-10T18:28:23Z

📌 Commit 434d6d3 has been approved by weihanglo

It is now in the queue for this repository.

bors · 2024-07-10T18:54:06Z

⌛ Testing commit 434d6d3 with merge 17b52b0...

bors · 2024-07-10T19:27:33Z

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 17b52b0 to master...

Update cargo 31 commits in 154fdac39ae9629954e19e9986fd2cf2cdd8d964..a2b58c3dad4d554ba01ed6c45c41ff85390560f2 2024-07-07 01:28:23 +0000 to 2024-07-16 00:52:02 +0000 - chore(ci): bump CI tools (rust-lang/cargo#14257) - test: migrate fetch and list_availables to snapbox (rust-lang/cargo#14214) - chore: downgrade to jobserver@0.1.28 (rust-lang/cargo#14254) - perf(source): Don't `du` on every git source load (rust-lang/cargo#14252) - fix(source): Don't warn about unreferenced duplicate packages (rust-lang/cargo#14239) - feat(test): Add cargo_test to test-support prelude (rust-lang/cargo#14243) - Add workflow to publish Cargo automatically (rust-lang/cargo#14202) - test: migrate implicit_features to snapbox (rust-lang/cargo#14245) - test: migrate build-std/main to snapbox (rust-lang/cargo#14241) - test: migrate check_cfg to snapbox (rust-lang/cargo#14235) - refactor(source): More RecursivePathSource clean up (rust-lang/cargo#14231) - Add more profiling traces (rust-lang/cargo#14238) - fix(overrides): Don't warn on duplicate packages from using '..' (rust-lang/cargo#14234) - fix(test): Redact elapsed time in the minutes time frame (rust-lang/cargo#14233) - test: Migrate lto tests to snapbox (rust-lang/cargo#14209) - fix: Ensure dep/feature activates the dependency on 2024 (rust-lang/cargo#14221) - chore(docs): update index of reference (rust-lang/cargo#14228) - test: migrate test to snapbox (rust-lang/cargo#14226) - chore: remove duplicate words (rust-lang/cargo#14229) - docs(contrib): Document things I look for in RFCs (rust-lang/cargo#14222) - docs(ref): Note MSRV for features in the docs (rust-lang/cargo#14224) - test(progress): Resolve flakiness (rust-lang/cargo#14223) - fix(test): Reduce over-prescription to the caller (rust-lang/cargo#14217) - refactor: move get_source_id out of registry (rust-lang/cargo#14218) - fix: rename to `rustdoc::broken_intra_doc_links` (rust-lang/cargo#14215) - test: migrate member_errors, multitarget and new to snapbox (rust-lang/cargo#14210) - test: migrate generate_lockfile and glob_targets to snapbox (rust-lang/cargo#14200) - test: Ensure --list test works with cargo-bloat (rust-lang/cargo#14213) - dont make new constant InternedString in hot path (rust-lang/cargo#14211) - Fix compatible_with_older_cargo test. (rust-lang/cargo#14212) - test: migrate metabuild, metadata and net_config to snapbox (rust-lang/cargo#14162)

rustbot assigned epage Jul 8, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 8, 2024

dieterplex force-pushed the migrate-lto-snapbox branch from 9d6d1ce to 668927a Compare July 8, 2024 05:52

epage reviewed Jul 8, 2024

View reviewed changes

tests/testsuite/lto.rs Outdated Show resolved Hide resolved

dieterplex force-pushed the migrate-lto-snapbox branch from 668927a to 18d7589 Compare July 9, 2024 01:13

bors added a commit that referenced this pull request Jul 9, 2024

Auto merge of #14209 - dieterplex:migrate-lto-snapbox, r=<try>

54fd320

test: Migrate lto tests to snapbox Part of #14039.

This was referenced Jul 9, 2024

fix: rename to rustdoc::broken_intra_doc_links #14215

Merged

Port from bespoke assertions of snapbox #14039

Open

weihanglo mentioned this pull request Jul 9, 2024

fix(test): Reduce over-prescription to the caller #14217

Merged

weihanglo reviewed Jul 9, 2024

View reviewed changes

tests/testsuite/lto.rs Outdated Show resolved Hide resolved

bors added a commit that referenced this pull request Jul 9, 2024

Auto merge of #14215 - weihanglo:rustdoc, r=ehuss

caf36ef

fix: rename to `rustdoc::broken_intra_doc_links` Found in <#14209 (comment)>.

test: Migrate lto tests to snapbox

434d6d3

dieterplex force-pushed the migrate-lto-snapbox branch from 18d7589 to 434d6d3 Compare July 10, 2024 04:33

weihanglo approved these changes Jul 10, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2024

bors merged commit 17b52b0 into rust-lang:master Jul 10, 2024
22 checks passed

bors mentioned this pull request Jul 10, 2024

Report codegen timings for binary crates #10960

Closed

dieterplex deleted the migrate-lto-snapbox branch July 11, 2024 01:00

weihanglo mentioned this pull request Jul 17, 2024

Update cargo rust-lang/rust#127838

Merged

rustbot added this to the 1.81.0 milestone Jul 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Migrate lto tests to snapbox #14209

test: Migrate lto tests to snapbox #14209

dieterplex commented Jul 8, 2024

rustbot commented Jul 8, 2024

dieterplex commented Jul 8, 2024

epage commented Jul 8, 2024

dieterplex commented Jul 9, 2024 •

edited

Loading

weihanglo commented Jul 9, 2024

bors commented Jul 9, 2024

bors commented Jul 9, 2024

weihanglo commented Jul 10, 2024

bors commented Jul 10, 2024

bors commented Jul 10, 2024

bors commented Jul 10, 2024

test: Migrate lto tests to snapbox #14209

test: Migrate lto tests to snapbox #14209

Conversation

dieterplex commented Jul 8, 2024

rustbot commented Jul 8, 2024

dieterplex commented Jul 8, 2024

epage commented Jul 8, 2024

dieterplex commented Jul 9, 2024 • edited Loading

weihanglo commented Jul 9, 2024

bors commented Jul 9, 2024

bors commented Jul 9, 2024

weihanglo commented Jul 10, 2024

bors commented Jul 10, 2024

bors commented Jul 10, 2024

bors commented Jul 10, 2024

dieterplex commented Jul 9, 2024 •

edited

Loading