Use gmake on AIX #14323
Use gmake on AIX #14323
Conversation
rustbot
added
the
S-waiting-on-review
| @@ -57,6 +57,8 @@ fn validate(_: &str) { | |||
| fn make_exe() -> &'static str { | |||
| if cfg!(windows) { | |||
| "mingw32-make" | |||
| } else if cfg!(target_os = "aix") { | |||
There was a problem hiding this comment.
Thanks for the fix.
As I have mentioned earlier, we are not able to verify if this is the correct fix. Some questions:
- Is GNU Make always installed as
gmakeon IBM AIX (I know thegprefix is a convention though)? - Would it be more preferable that downstream exclude these tests when running the test suite?
This is for test only and doesn't look bad, so I am not going to block this :)
There was a problem hiding this comment.
Is GNU Make always installed as gmake on IBM AIX (I know the g prefix is a convention though)?
Yes. It's installed via https://www.ibm.com/support/pages/aix-toolbox-open-source-software-downloads-alpha and there will be symbol link named /usr/bin/gmake which links to /opt/freeware/bin/make.
Would it be more preferable that downstream exclude these tests when running the test suite?
Since adding CI for AIX on github is hard, but we also want to deliver the same quality as tier-1 targets, we are maintaining an internal CI on AIX, running almost the same CI tasks(testing, packaging, stable/beta/nightly channel shifting...) as rust-lang org does. So for our strategy, we try our best to upstream changes for AIX, while not to break community's CI.
There was a problem hiding this comment.
Sounds great. Thanks for your reply!
| @@ -57,6 +57,8 @@ fn validate(_: &str) { | |||
| fn make_exe() -> &'static str { | |||
| if cfg!(windows) { | |||
| "mingw32-make" | |||
| } else if cfg!(target_os = "aix") { | |||
There was a problem hiding this comment.
Sounds great. Thanks for your reply!
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Update cargo 15 commits in 257b72b8adfb1f2aa9916cefca67285c21666276..fa646583675d7c140482bd906145c71b7fb4fc2b 2024-07-30 15:08:27 +0000 to 2024-08-02 16:08:06 +0000 - refactor(toml): Rename 'resolved' to 'normalized' (rust-lang/cargo#14342) - faq: rephrase offline usage. (rust-lang/cargo#14336) - docs(unstable): Improve nightly link (rust-lang/cargo#14344) - Fix a typo in 1.81 changes (rust-lang/cargo#14343) - Change tests to support `rustc` wording changes (rust-lang/cargo#14341) - chore(deps): update rust crate windows-sys to 0.59 (rust-lang/cargo#14335) - chore(deps): update rust crate gix to 0.64.0 (rust-lang/cargo#14332) - chore(deps): update compatible (rust-lang/cargo#14331) - chore(deps): update rust crate rusqlite to 0.32.0 (rust-lang/cargo#14334) - fix: also build manpage for cargo.md (rust-lang/cargo#14339) - fix(config): Adjust MSRV resolve config field name / values (rust-lang/cargo#14296) - fix(toml): Resolve regression from toml_edit 0.22.18 (rust-lang/cargo#14329) - test(publish): More dev-dep stripping cases (rust-lang/cargo#14327) - Use gmake on AIX (rust-lang/cargo#14323) - fix(publish): Don't strip non-dev features (rust-lang/cargo#14325) r? ghost
AIX's
makeis different from GNU's make. Use GNU's make on AIX for tests instead.Reference https://www.ibm.com/docs/en/aix/7.2?topic=m-make-command.