Be more permissive while packaging unpublishable crates. #14408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-interacts-with-crates.io
epage
reviewed
Aug 15, 2024
epage
reviewed
Aug 15, 2024
epage
reviewed
Aug 15, 2024
jneem
force-pushed
the
infer-registry-ignore-unpublishable
branch
from
763ee29
to
3afd758
Compare
|
☔ The latest upstream changes (presumably #14326) made this pull request unmergeable. Please resolve the merge conflicts. |
jneem
force-pushed
the
infer-registry-ignore-unpublishable
branch
from
3afd758
to
591993f
Compare
jneem
force-pushed
the
infer-registry-ignore-unpublishable
branch
from
591993f
to
9e553b0
Compare
jneem
force-pushed
the
infer-registry-ignore-unpublishable
branch
from
9e553b0
to
4ee3aef
Compare
|
Ok, I've split that commit further. We can drop the "Use the shared source building..." commit if you want; it changes some behavior mostly just to get some more code re-use. |
jneem
force-pushed
the
infer-registry-ignore-unpublishable
branch
from
4ee3aef
to
c3043c5
Compare
epage
reviewed
Aug 19, 2024
|
Thank you for splitting things out further. That was a big help in following what is happening! |
This changes the registry validation slightly, adding in a check forbidding implicit source replacement. This affects the tests (which configure a dummy registry for source replacement), so we also weaken the checks by only erroring for registry issues when there are actually local dependencies.
jneem
force-pushed
the
infer-registry-ignore-unpublishable
branch
from
c3043c5
to
96d4d6f
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 22, 2024
Update cargo 12 commits in ba8b39413c74d08494f94a7542fe79aa636e1661..8f40fc59fb0c8df91c97405785197f3c630304ea 2024-08-16 22:48:57 +0000 to 2024-08-21 22:37:06 +0000 - Tests rely on absence of RUST_BACKTRACE (rust-lang/cargo#14441) - fix: -Cmetadata includes whether extra rustflags is same as host (rust-lang/cargo#14432) - [mdman] Normalize newlines when rendering options (rust-lang/cargo#14428) - fix: doctest respects Cargo's color options (rust-lang/cargo#14425) - Be more permissive while packaging unpublishable crates. (rust-lang/cargo#14408) - fix: Limiting pre-release match semantics to use only on `OptVersionReq::Req` (rust-lang/cargo#14412) - test: add a regression test for Issue 14409 (rust-lang/cargo#14430) - chore: update label trigger for Command-info (rust-lang/cargo#14422) - doc: add lockfile-path unstable doc section (rust-lang/cargo#14423) - doc: update lockfile-path tracking issue (rust-lang/cargo#14424) - fix: remove list owners feature of info subcommand (rust-lang/cargo#14418) - Lockfile path tests (follow-up) (rust-lang/cargo#14417)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for packaging workspaces that include
publish = falsecrates, in some circumstances:This PR also contains a refactor, moving the registry inference logic to
registry/mod.rs, where it will be reused by the upcoming publish-workspace feature. I put the refactor and the logic changes in different commits.Fixes #14356