Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc fix for publish command synopsis #6749

Merged
merged 2 commits into from
Mar 15, 2019

Conversation

calebcartwright
Copy link
Member

I think the synopsis for the publish command doc should be cargo publish but it currently has package (screenshot below).

Took a shot at making the change, not positive I did it the correct way though 😄

image

@ehuss
Copy link
Contributor

ehuss commented Mar 15, 2019

Oops, thanks!!

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 15, 2019

📌 Commit fdd10e8 has been approved by ehuss

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 15, 2019
@bors
Copy link
Collaborator

bors commented Mar 15, 2019

⌛ Testing commit fdd10e8 with merge 434664612f090b3f9eb3c55a7c44204b4bea8b8c...

@ehuss
Copy link
Contributor

ehuss commented Mar 15, 2019

Oops, one more file needed updating.

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 15, 2019

📌 Commit 8be86b6 has been approved by ehuss

@bors
Copy link
Collaborator

bors commented Mar 15, 2019

⌛ Testing commit 8be86b6 with merge 5add0d79e00699ffdd8d0ffd75c364e06ed60566...

@bors
Copy link
Collaborator

bors commented Mar 15, 2019

💔 Test failed - checks-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 15, 2019
@ehuss
Copy link
Contributor

ehuss commented Mar 15, 2019

@bors retry

meta_test_multiple_versions_strategy #6613

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2019
@bors
Copy link
Collaborator

bors commented Mar 15, 2019

⌛ Testing commit 8be86b6 with merge 6b1810cba8a530b7abe596cc8325e0d00d96718c...

@bors
Copy link
Collaborator

bors commented Mar 15, 2019

💔 Test failed - checks-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 15, 2019
@ehuss
Copy link
Contributor

ehuss commented Mar 15, 2019

@bors retry
Spurious error with can_not_mix_doc_tests_and_regular_tests. It has me slightly baffled.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2019
@bors
Copy link
Collaborator

bors commented Mar 15, 2019

⌛ Testing commit 8be86b6 with merge 2ed31b0...

bors added a commit that referenced this pull request Mar 15, 2019
Minor doc fix for publish command synopsis

I think the synopsis for the [publish command doc]( https://doc.rust-lang.org/stable/cargo/commands/cargo-publish.html) should be `cargo publish` but it currently has `package` (screenshot below).

Took a shot at making the change, not positive I did it the correct way though 😄

![image](https://user-images.githubusercontent.com/13042488/54401497-e8b8b000-4695-11e9-872a-b467968af203.png)
@bors
Copy link
Collaborator

bors commented Mar 15, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: ehuss
Pushing 2ed31b0 to master...

@bors bors merged commit 8be86b6 into rust-lang:master Mar 15, 2019
@calebcartwright calebcartwright deleted the docs-publish-command branch March 15, 2019 04:24
bors added a commit to rust-lang/rust that referenced this pull request Mar 30, 2019
Update cargo

Update cargo

22 commits in 0e35bd8af0ec72d3225c4819b330b94628f0e9d0..63231f438a2b5b84ccf319a5de22343ee0316323
2019-03-13 06:52:51 +0000 to 2019-03-27 12:26:45 +0000
- Code cleanup (rust-lang/cargo#6787)
- Add cargo:rustc-link-arg to pass custom linker arguments (rust-lang/cargo#6298)
- Testsuite: remove some unnecessary is_nightly checks. (rust-lang/cargo#6786)
- cargo metadata: Don't show `null` deps. (rust-lang/cargo#6534)
- Some fingerprint cleanup. (rust-lang/cargo#6785)
- Fix fingerprint for canceled build script. (rust-lang/cargo#6782)
- Canonicalize default target if it ends with `.json` (rust-lang/cargo#6778)
- Fix setting `panic=unwind` compiling lib a extra time. (rust-lang/cargo#6781)
- Always nicely show errors from crates.io if possible (rust-lang/cargo#6771)
- Testsuite: Make `cwd()` relative to project root. (rust-lang/cargo#6768)
- Allow `cargo fix` if gitignore matches root working dir. (rust-lang/cargo#6767)
- Remove redundant imports (rust-lang/cargo#6763)
- Handle backcompat hazard with `toml` crate (rust-lang/cargo#6761)
- Fix spurious error in dirty_both_lib_and_test. (rust-lang/cargo#6756)
- Update toml requirement from 0.4.2 to 0.5.0 (rust-lang/cargo#6760)
- Reuse std::env::consts::EXE_SUFFIX (rust-lang/cargo#6758)
- Proptest 0.9.1 (rust-lang/cargo#6753)
- Don't need extern crate in 2018 (rust-lang/cargo#6752)
- Release a jobserver token while locking a file (rust-lang/cargo#6748)
- Minor doc fix for publish command synopsis (rust-lang/cargo#6749)
- Stricter package change detection. (rust-lang/cargo#6740)
- Fix resolving yanked crates when using a local registry. (rust-lang/cargo#6742)
@ehuss ehuss added this to the 1.35.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants