Symlink dSYM on macOS example binaries. #6891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit f95f55a has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Apr 30, 2019
Symlink dSYM on macOS example binaries. Examples previously ended up with a layout such as: ``` target/debug/examples/ex1 target/debug/examples/ex1.d target/debug/examples/ex1-966e505ad4696130 target/debug/examples/ex1-966e505ad4696130.d target/debug/examples/ex1-966e505ad4696130.dSYM/… ``` If you attempt to run lldb on the executable without the hash (`target/debug/examples/ex1`), then symbols could not be found. This PR solves this by creating a symlink from `ex1.dSYM -> ex1-966e505ad4696130.dSYM`. Closes #6889
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples previously ended up with a layout such as:
If you attempt to run lldb on the executable without the hash (
target/debug/examples/ex1), then symbols could not be found. This PR solves this by creating a symlink fromex1.dSYM -> ex1-966e505ad4696130.dSYM.Closes #6889