Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testsuite: Use split debuginfo on macos. #9207

Merged
merged 1 commit into from
Feb 25, 2021
Merged

testsuite: Use split debuginfo on macos. #9207

merged 1 commit into from
Feb 25, 2021

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Feb 25, 2021

This switches the testsuite to use "unpacked" debuginfo on macos, which is a substantial performance boost. On my system, the testsuite runs 1.55 times faster with this change. Along with #9206, total testsuite time is 3.1 times faster.

@rust-highfive
Copy link

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 25, 2021
@Eh2406
Copy link
Contributor

Eh2406 commented Feb 25, 2021

Worth a try, we can always back it out if it breaks something.

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 25, 2021

📌 Commit 0f78dbd has been approved by Eh2406

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2021
@alexcrichton
Copy link
Member

Along with #9206, total testsuite time is 3.1 times faster

Phew!

I'm always scared that it's small things like this which slow things down and unless we're actively developing on the platform and feeling the pain not much tends to happen...

looks at windows

@bors
Copy link
Collaborator

bors commented Feb 25, 2021

⌛ Testing commit 0f78dbd with merge 17fe256a38010ebc107f9ad238f60c9c5fe2c23d...

@bors
Copy link
Collaborator

bors commented Feb 25, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 25, 2021
@ehuss
Copy link
Contributor Author

ehuss commented Feb 25, 2021

@bors retry

E: Failed to fetch http://security.ubuntu.com/ubuntu/dists/focal-security/main/i18n/Translation-en.xz File has unexpected size (111640 != 111832). Mirror sync in progress? [IP: 91.189.91.39 80]

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2021
@bors
Copy link
Collaborator

bors commented Feb 25, 2021

⌛ Testing commit 0f78dbd with merge 6780fbd...

@bors
Copy link
Collaborator

bors commented Feb 25, 2021

☀️ Test successful - checks-actions
Approved by: Eh2406
Pushing 6780fbd to master...

@bors bors merged commit 6780fbd into rust-lang:master Feb 25, 2021
@ehuss ehuss mentioned this pull request Mar 3, 2021
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 3, 2021
@JohnTitor
Rollup merge of rust-lang#82713 - ehuss:update-cargo, r=ehuss
374c90b 
Update cargo

12 commits in 572e201536dc2e4920346e28037b63c0f4d88b3c..c68432f1e5cbbc09833699a951b1b5b059651dff
2021-02-24 16:51:20 +0000 to 2021-03-02 18:26:29 +0000
- Don't panic when printing JSON with non-utf8 paths (rust-lang/cargo#9226)
- Detect changes for JSON spec targets. (rust-lang/cargo#9223)
- Fix `cargo_target_empty_cfg` test with env var. (rust-lang/cargo#9225)
- Correct default cargo new edition (rust-lang/cargo#9202)
- Update split-debuginfo docs around the default. (rust-lang/cargo#9224)
- Minor update to registry API error messages. (rust-lang/cargo#9213)
- Some minor code cleanup. (rust-lang/cargo#9214)
- doc: Fix spelling worksapce->workspace (rust-lang/cargo#9212)
- Update SPDX version in docs. (rust-lang/cargo#9209)
- Throw error if CARGO_TARGET_DIR is an empty string (rust-lang/cargo#8939)
- testsuite: Use split debuginfo on macos. (rust-lang/cargo#9207)
- testsuite: Improve performance when using rustup. (rust-lang/cargo#9206)
@ehuss ehuss added this to the 1.52.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Eh2406 Eh2406

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ehuss @rust-highfive @Eh2406 @bors @alexcrichton