Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't separate files/opt when using msvc assembler #747

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

roblabla
Copy link
Contributor

@roblabla roblabla commented Nov 8, 2022

The MSVC assemblers don't support using -- to mark the end of the options and the start of the "verbatim" file list. When the compiler family is MSVC with clang-cl, the assembler used will be the standard MSVC assembler.

See rust-lang/rust#104152 (comment)

The MSVC assemblers don't support using `--` to mark the end of the
options and the start of the "verbatim" file list. When the compiler
family is MSVC with clang-cl, the assembler used will be the standard
MSVC assembler.
Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@thomcc thomcc merged commit 0e5b395 into rust-lang:main Nov 8, 2022
@thomcc
Copy link
Member

thomcc commented Nov 8, 2022

If this fixes rust-lang/rust I'll try to get a hotfix release out later today or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants