Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept RFC 2951 "Linking modifiers for native libraries" #356

Closed
1 of 3 tasks
petrochenkov opened this issue Sep 4, 2020 · 12 comments
Closed
1 of 3 tasks

Accept RFC 2951 "Linking modifiers for native libraries" #356

petrochenkov opened this issue Sep 4, 2020 · 12 comments
Labels
disposition-merge The FCP starter wants to merge this finished-final-comment-period The FCP has finished, action upon the disposition label needs to be taken major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@petrochenkov
Copy link

petrochenkov commented Sep 4, 2020 •
edited
Loading

Proposal

Accept RFC 2951 "Linking modifiers for native libraries" that provides some generic syntax (similar to target features) for linking modifiers used for native libraries, and introduces some specific modifiers to control bundling behavior, whole-archive linking and library name mangling.

Mentors or Reviewers

@petrochenkov

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@petrochenkov petrochenkov added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Sep 4, 2020
@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2020

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Sep 4, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Sep 9, 2020
@pnkfelix
Copy link
Member

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Sep 11, 2020
@pnkfelix
Copy link
Member

I just re-read the protocol and realized that this requires full team check off.

@pnkfelix
Copy link
Member

@rustbot fcp cancel

@pnkfelix pnkfelix removed the final-comment-period The FCP has started, most (if not all) team members are in agreement label Sep 11, 2020
@pnkfelix
Copy link
Member

@rustbot fcp merge

@pnkfelix
Copy link
Member

@rfcbot rfc merge

@pnkfelix
Copy link
Member

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Sep 11, 2020 •
edited by nikomatsakis
Loading

Team member @pnkfelix has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period An FCP has been started, cast your votes and raise concerns disposition-merge The FCP starter wants to merge this labels Sep 11, 2020
@petrochenkov petrochenkov mentioned this issue Oct 9, 2020
Merged
@nikomatsakis
Copy link
Contributor

@rfcbot reviewed

@rfcbot rfcbot added final-comment-period The FCP has started, most (if not all) team members are in agreement and removed proposed-final-comment-period An FCP has been started, cast your votes and raise concerns labels Oct 20, 2020
@rfcbot
Copy link

rfcbot commented Oct 20, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The FCP has finished, action upon the disposition label needs to be taken to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Oct 30, 2020
@rfcbot
Copy link

rfcbot commented Oct 30, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Nov 5, 2020
@nikomatsakis nikomatsakis added the major-change-accepted A major change proposal that was accepted label Dec 1, 2020
@nikomatsakis
Copy link
Contributor

Accepted!

@nikomatsakis nikomatsakis mentioned this issue Dec 2, 2020
Merged
@petrochenkov petrochenkov mentioned this issue Jan 28, 2021
Closed
3 tasks
@luqmana luqmana mentioned this issue Mar 26, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue May 5, 2021
@Dylan-DPC
Rollup merge of rust-lang#83507 - luqmana:native-link-modifiers, r=pe…
2d9234e 
…trochenkov

Implement RFC 2951: Native link modifiers

A first attempt at implementing rust-lang/rfcs#2951 / rust-lang/compiler-team#356.

Tracking Issue: rust-lang#81490

Introduces feature flags for the general syntax (`native_link_modifiers`) and each modifier (`native_link_modifiers_{as_needed,bundle,verbatim,whole_archive}`).

r? `@petrochenkov`
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue May 6, 2021
@Dylan-DPC
Rollup merge of rust-lang#83507 - luqmana:native-link-modifiers, r=pe…
5dcdeb8 
…trochenkov

Implement RFC 2951: Native link modifiers

A first attempt at implementing rust-lang/rfcs#2951 / rust-lang/compiler-team#356.

Tracking Issue: rust-lang#81490

Introduces feature flags for the general syntax (`native_link_modifiers`) and each modifier (`native_link_modifiers_{as_needed,bundle,verbatim,whole_archive}`).

r? `@petrochenkov`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
disposition-merge The FCP starter wants to merge this finished-final-comment-period The FCP has finished, action upon the disposition label needs to be taken major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@spastorino @nikomatsakis @pnkfelix @petrochenkov @rfcbot @rustbot