Update for uniform_path stabilization. #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
reviewed
Jan 30, 2019
| submodule. You can always use a relative path from the current module, a path | ||
| starting from an external crate name, or a path starting with `crate`, `super`, | ||
| or `self`. | ||
| other code almost always work the same way, both in the top-level module and |
There was a problem hiding this comment.
The "almost" bit here will leave the reader wondering...
There was a problem hiding this comment.
😆 I think I have a list of some of the differences, but I don't think it is complete, and the differences are usually quite obscure. Definitely reference-only material. It does briefly mention at the bottom of the section about ambiguities, which is one of the differences. I just felt that "always" was making a strong assertion that wasn't true.
There was a problem hiding this comment.
Maybe: "paths in use declarations and in other code work the same way, ..." (i.e. just remove "always").
This is less "100% sure" but also doesn't say "maybe, we are not sure".
|
FYI, https://rust-lang-nursery.github.io/edition-guide/rust-2018/module-system/path-clarity.html Should this badge get updated now that 1.32 has uniform paths?
|
|
@johnthagen this PR updates the badge. Ping @Centril or @steveklabnik is there anything else you'd like to see for this PR? |
|
@ehuss I think I just forgot about the PR... sorry :) |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 28, 2019
Update edition-guide 15 commits in 419edb885ec1a98c0747b3907003d79e3e6b93a9..5f3cc2a5618700efcde3bc00799744f21fa9ad2e 2018-12-04 16:43:38 -0500 to 2019-02-27 20:11:50 -0800 - Migrate to mdbook 0.2. (rust-lang/edition-guide#152) - Remove automatic deployment. (rust-lang/edition-guide#151) - Fix issue with rust's linkchecker and mdbook. (rust-lang/edition-guide#147) - Fix test now that overflowing_literals is rejected in all editions. (rust-lang/edition-guide#148) - overflowing_literals is deny on all editions (rust-lang/edition-guide#146) - Update for uniform_path stabilization. (rust-lang/edition-guide#141) - Add example to rustup to show overriding to specific version (rust-lang/edition-guide#144) - Update for anonymous-lifetime stabilization. (rust-lang/edition-guide#142) - Add minimum Rust version for Kleene operator (rust-lang/edition-guide#137) - Add 2018-specific changes. (rust-lang/edition-guide#130) - aborting-on-panic.md: Typo in example config (rust-lang/edition-guide#125) - Clarify uniform paths are not yet in Rust 2018 (rust-lang/edition-guide#124) - update several version numbers - Fixes outdated link (rust-lang/edition-guide#131) - Fixed typo in transitioning page. (rust-lang/edition-guide#127)
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Mar 1, 2019
Update edition-guide 15 commits in 419edb885ec1a98c0747b3907003d79e3e6b93a9..5f3cc2a5618700efcde3bc00799744f21fa9ad2e 2018-12-04 16:43:38 -0500 to 2019-02-27 20:11:50 -0800 - Migrate to mdbook 0.2. (rust-lang/edition-guide#152) - Remove automatic deployment. (rust-lang/edition-guide#151) - Fix issue with rust's linkchecker and mdbook. (rust-lang/edition-guide#147) - Fix test now that overflowing_literals is rejected in all editions. (rust-lang/edition-guide#148) - overflowing_literals is deny on all editions (rust-lang/edition-guide#146) - Update for uniform_path stabilization. (rust-lang/edition-guide#141) - Add example to rustup to show overriding to specific version (rust-lang/edition-guide#144) - Update for anonymous-lifetime stabilization. (rust-lang/edition-guide#142) - Add minimum Rust version for Kleene operator (rust-lang/edition-guide#137) - Add 2018-specific changes. (rust-lang/edition-guide#130) - aborting-on-panic.md: Typo in example config (rust-lang/edition-guide#125) - Clarify uniform paths are not yet in Rust 2018 (rust-lang/edition-guide#124) - update several version numbers - Fixes outdated link (rust-lang/edition-guide#131) - Fixed typo in transitioning page. (rust-lang/edition-guide#127)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a rough stab at improving things, or at least removing some of the wrong information. I think more details will need to wait for the reference.
I rewrote
Changes to pathsbecause it no longer matched what current 2018 code should look like, and had a lot of overlap with what "uniform paths" was saying. I replaced it with something roughly describing extern prelude, which I think fits?Closes #139.