Check in CI that the crate builds on targets without libstd #110
Conversation
|
cc @tkaitchuck: This is blocked on |
|
@tkaitchuck It seems that public dependencies ( |
|
Hmm I'm not sure why this worked before though... |
|
Oh it's because |
|
@tkaitchuck Can you please remove |
|
Done. Const_random 0.1.6. |
|
@bors r+ |
|
📌 Commit 8a3654c has been approved by |
Check in CI that the crate builds on targets without libstd Fixes #109
|
💔 Test failed - checks-travis |
|
@bors retry |
Check in CI that the crate builds on targets without libstd Fixes #109
|
💔 Test failed - checks-travis |
|
@tkaitchuck |
|
@tkaitchuck Also, |
|
The Make sure you have the mingw linker properly set up in ~/.cargo/config |
|
I saw two issues with running that command the first was: But I assume based on your comment about the config that this is not what you are referring to. The second issue was due to the optimizer not being aggressive enough. I've fixed this is 0.2.10. Hopefully that resolves the issue |
|
@tkaitchuck Windows builds are still failing, I think you need to mark the |
|
Ok, done. |
|
The builds seem to be fixed now. I'm just waiting on rust-lang/rust#63302 to land on nightly for the thumbv6m fix. By the way, |
The reason it was still failing is because the profile flags in Cargo.toml are only taken into account when building that crate directly. They are ignored when a crate is built as a dependency. |
|
@bors r+ |
|
📌 Commit 3239c2b has been approved by |
Check in CI that the crate builds on targets without libstd Fixes #109
|
💔 Test failed - checks-travis |
|
@bors r+ |
|
📌 Commit 8ae33c9 has been approved by |
Check in CI that the crate builds on targets without libstd Fixes #109
|
💔 Test failed - checks-travis |
|
@bors retry |
Check in CI that the crate builds on targets without libstd Fixes #109
|
☀️ Test successful - checks-travis |
Fixes #109