fix: preadv2 only available on GNU libc #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you help do a |
Technically it is also available on musl libc 1.2.5, yet the libc@0.2.153 (lastet) doesn't export the symbol, and that version of musl libc is too new (released in 2024-03)
|
@weihanglo @NobodyXu |
|
It looks great. It also failed without this PR and now passed, so r+. |
|
#82 is just merged. |
|
Published 0.1.30 and yanked 0.1.29. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technicially it is also available on musl libc 1.2.5,
yet the libc@0.2.153 (lastet) doesn't export the symbol,
and that version of musl libc is too new (released in 2024-03)
Fixes #79. Tested against Rust docker image alpine3.18