Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IOV_MAX and UIO_MAXIOV constants #1880

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Add IOV_MAX and UIO_MAXIOV constants #1880

merged 1 commit into from
Sep 2, 2020

Conversation

Thomasdezeeuw
Copy link
Contributor

These constant can be used to determine the maximum number of iovecs can
be passed to functions like readv/writev.

Linux like uses UIO_MAXIOV, while the BSD family uses IOV_MAX.

These constant can be used to determine the maximum number of iovecs can
be passed to functions like readv/writev.

Linux like uses UIO_MAXIOV, while the BSD family uses IOV_MAX.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Thomasdezeeuw
Copy link
Contributor Author

I don't know how to add tests for these constants. I also couldn't run the tests locally as it failed with a huge list of errors.

@Thomasdezeeuw Thomasdezeeuw marked this pull request as ready for review August 28, 2020 14:41
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JohnTitor JohnTitor merged commit f19436d into rust-lang:master Sep 2, 2020
@Thomasdezeeuw Thomasdezeeuw deleted the io-max-consts branch September 2, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants