Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use link modifiers -bundle on musl and wasi target #2272

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

Please see the contribution instructions for more information.

@bors
Copy link
Contributor

bors commented Jul 6, 2021

☔ The latest upstream changes (presumably #2271) made this pull request unmergeable. Please resolve the merge conflicts.

@12101111 12101111 changed the title [WIP] Use link modifiers -bundle on musl and wasi target Use link modifiers -bundle on musl and wasi target Nov 3, 2021
@12101111
Copy link
Contributor Author

12101111 commented Nov 3, 2021

Hello world don't compile on aarch64-unknown-linux-musl now.

It seems this pr will fix this, see rust-lang/rust#89626 (comment)

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 3, 2021
Provide standalone libc.a in self-contained for musl and wasi

This is a prerequisites of rust-lang/libc#2272, which in turn fix:

- rust-lang/wg-cargo-std-aware#66
- rust-lang#89626
@Amanieu
Copy link
Member

Amanieu commented Nov 4, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Nov 4, 2021

📌 Commit fd331f6 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Nov 4, 2021

⌛ Testing commit fd331f6 with merge 74c3913...

bors added a commit that referenced this pull request Nov 4, 2021
Use link modifiers -bundle on musl and wasi target

Implement rust-lang/rust#72274

Fix:

- rust-lang/wg-cargo-std-aware#66
- rust-lang/rust#89626

TODO:

- [x] Implement rustbuild side change: rust-lang/rust#90527
@bors
Copy link
Contributor

bors commented Nov 4, 2021

💔 Test failed - checks-actions

@12101111
Copy link
Contributor Author

12101111 commented Nov 4, 2021

broken_heart Test failed - checks-actions

Network failure

info: downloading component 'rustc'
info: retrying download for 'https://static.rust-lang.org/dist/2021-11-04/rustc-nightly-x86_64-apple-darwin.tar.xz'
info: retrying download for 'https://static.rust-lang.org/dist/2021-11-04/rustc-nightly-x86_64-apple-darwin.tar.xz'
info: retrying download for 'https://static.rust-lang.org/dist/2021-11-04/rustc-nightly-x86_64-apple-darwin.tar.xz'
info: retrying download for 'https://static.rust-lang.org/dist/2021-11-04/rustc-nightly-x86_64-apple-darwin.tar.xz'
error: component download failed for rustc-x86_64-apple-darwin: could not download file from 'https://static.rust-lang.org/dist/2021-11-04/rustc-nightly-x86_64-apple-darwin.tar.xz' to '/Users/runner/.rustup/downloads/0c18cbfe1f653fa88a0ea659d91730320360ee26cdaaf1f4c3b135f2e0ddf52e.partial'

@Amanieu
Copy link
Member

Amanieu commented Nov 4, 2021

@bors retry

@bors
Copy link
Contributor

bors commented Nov 4, 2021

⌛ Testing commit fd331f6 with merge 3b1f0ba...

bors added a commit that referenced this pull request Nov 4, 2021
Use link modifiers -bundle on musl and wasi target

Implement rust-lang/rust#72274

Fix:

- rust-lang/wg-cargo-std-aware#66
- rust-lang/rust#89626

TODO:

- [x] Implement rustbuild side change: rust-lang/rust#90527
@bors
Copy link
Contributor

bors commented Nov 4, 2021

💔 Test failed - checks-actions

@Amanieu
Copy link
Member

Amanieu commented Nov 4, 2021

@bors retry

@bors
Copy link
Contributor

bors commented Nov 4, 2021

⌛ Testing commit fd331f6 with merge 3bde54f...

@bors
Copy link
Contributor

bors commented Nov 4, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 3bde54f to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants