Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate "name" attribute on input #1509

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Remove duplicate "name" attribute on input #1509

merged 1 commit into from
Apr 26, 2021

Conversation

GuillaumeGomez
Copy link
Member

I discovered this issue while working on rust-lang/rust#84480.

ehuss
ehuss approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not entirely certain this won't break anything, but it seems to work. The URL (which uses the key search) seems to always be handled manually in javascript. I have no idea what browsers' behavior is with multiple name fields.

@ehuss ehuss merged commit b54e73e into rust-lang:master Apr 26, 2021
@GuillaumeGomez GuillaumeGomez deleted the duplicate-name branch April 26, 2021 11:46
@GuillaumeGomez
Copy link
Member Author

From what I could read, the last "apparition" of the attribute overwrite the previous one.

@ehuss ehuss mentioned this pull request Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeGomez @ehuss