Fix compilation error and regression tests for big endian platforms #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons-rs. This also fixes a bug where the workflow actually did not compile/check the code for a big-endian target. wip
michaelwoerister
force-pushed
the
fix-gh-actions-rust-toolchain
branch
3 times, most recently
from
2c16a2b
to
ec4751a
Compare
michaelwoerister
changed the title
michaelwoerister
changed the title
michaelwoerister
force-pushed
the
fix-gh-actions-rust-toolchain
branch
2 times, most recently
from
de43237
to
fa771da
Compare
michaelwoerister
force-pushed
the
fix-gh-actions-rust-toolchain
branch
from
0d1fb56
to
f0fffe1
Compare
wesleywiser
approved these changes
Jan 5, 2024
|
@bors r=wesleywiser |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the big endian regression tests. Apparently, the have not actually run
cargo checkwith a big endian target for a while. The PR also switches the GH action jobs to use a matrix and replaces the unmaintained action-rs with something more current. It also fixes the big-endian-only compilation error that the now fixed tests are running into.This should unblock rust-lang/rust#119111, once we've done a 11.0.1 release.
r? @wesleywiser