Virtual instead of reserved string ids #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelwoerister
force-pushed
the
virtual-instead-of-reserved-string-ids
branch
from
e7cefe5
to
269c959
Compare
wesleywiser
requested changes
Dec 9, 2019
…pt of virtual StringIds. With this commit only "virtual" StringIds get an entry in the index table and regular StringIds store an actual address instead of index table key. That makes the index data a lot smaller and removes the need to do a table lookup for regular StringIds.
michaelwoerister
force-pushed
the
virtual-instead-of-reserved-string-ids
branch
from
269c959
to
47ca752
Compare
wesleywiser
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some unnecessary overhead from the StringTable format.
This optimization becomes important when recording query keys because we allocate a lot more string data in that case.
This PR also contains the changes from #97. Feel free to review/merge all at once or separately.