implement more casts #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -244,6 +246,8 @@ impl<'a, 'tcx> EvalContext<'a, 'tcx> { | |||
| } | |||
|
|
|||
| fn type_is_sized(&self, ty: Ty<'tcx>) -> bool { | |||
| // generics are weird, don't run this function on a generic | |||
| debug_assert_eq!(self.monomorphize(ty, self.substs()), ty); | |||
There was a problem hiding this comment.
You can check this with ty.needs_substs() which is basically free.
IMO debug_assert is bad in the compiler (compared to always-on cheap checks) because users won't trigger it.
|
@oli-obk AFAICT this doesn't have unsizing. |
|
unsizing has its own variant |
|
|
|
good point... so yea, the last box should be checked, but we need to wait for vtables now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure if this is all of #26